Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log stop ssh repo #25552

Closed
m2nlight opened this issue Jun 28, 2023 · 2 comments
Closed

Log stop ssh repo #25552

m2nlight opened this issue Jun 28, 2023 · 2 comments
Labels

Comments

@m2nlight
Copy link

Description

I cannot clone a ssh address repo.
The binary name: gitea-1.20-Gogot-windows4.0-amd64

I found this: [W] ScriptType "bash" is not on the current PATH throgh ssh -vvv command.
It is a log info.

Then, I add a git-bash path to environment variable PATH to solved logger output. (Ref: #20580)

Gitea Version

1.20.0+rc2-12-g102dcfa3a

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Gitea on windows

Database

None

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 28, 2023

The log problem will be fixed by

(by a backport #25553)

@m2nlight
Copy link
Author

That's great!

lunny pushed a commit that referenced this issue Jun 28, 2023
Backport #25537

More fix for #24981

* #24981

Close #22361, #25552

* #22361
* #25552

There were many patches for Gitea's sub-commands to satisfy the facts:

* Some sub-commands shouldn't output any log, otherwise the git protocol
would be broken
* Sometimes the users want to see "verbose" or "quiet" outputs

That's a longstanding problem, and very fragile. This PR is only a quick
patch for the problem.

In the future, the sub-command system should be refactored to a clear
solution.

----

Other changes:

* Use `ReplaceAllWriters` to replace
`RemoveAllWriters().AddWriters(writer)`, then it's an atomic operation.
* Remove unnecessary `syncLevelInternal` calls, because
`AddWriters/addWritersInternal` already calls it.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants