Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding for Clone Options button #25758

Closed
C-EO opened this issue Jul 7, 2023 · 2 comments · Fixed by #25763
Closed

Padding for Clone Options button #25758

C-EO opened this issue Jul 7, 2023 · 2 comments · Fixed by #25763
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@C-EO
Copy link

C-EO commented Jul 7, 2023

Description

Described in heading.

Screenshots

image

Gitea Version

1.21.0+dev-242-ga6a9389c7

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

linux 5.19.0-1026-gcp

Browser Version

Microsoft Edge 114.0.1823.67 (Official build) (64-bit)
@C-EO C-EO added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 7, 2023
@delvh
Copy link
Member

delvh commented Jul 7, 2023

Responsible element/ CSS rule:
grafik
Apparently, no one expected that there is a matching button without a triangle icon.

@delvh delvh mentioned this issue Jul 8, 2023
Merged
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 8, 2023 •
edited
Loading

Oops, I didn't notice this issue in first time. Thank you for linking the PR with it (the padding was fixed in #25763 by the way, side effect 🤣 )

silverwind pushed a commit that referenced this issue Jul 8, 2023
@wxiaoguang @GiteaBot
Clarify "text-align" CSS helpers, fix clone button padding (#25763)
cc00fd5 
Changes:

* Rename gt-tl/gt-tc/gt-tr to gt-text-left/gt-text-center/gt-text-right
* The gt-ab and gt-br-0 are removed because they are not needed anymore
* Fix the clone dropdown button padding by ":not(.icon)"

Before:

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/eb030633-622c-4ca7-8e88-ce010d9f51a6)

</details>

After:

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/64c09403-bf21-439c-88f1-780b34ccab6b)

</details>

Fixes #25758

Co-authored-by: Giteabot <teabot@gitea.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify "text-align" CSS helpers, fix clone button padding wxiaoguang/gitea
3 participants
@wxiaoguang @delvh @C-EO