-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot edit in WebEditor, keeps showing loading #25770
Comments
It is working fine. https://try.git.io is a demo server with low configuration. I have also tried in my local dev server. Its working fine. You can try the prod server https://gitea.com/user/sign_up |
It's a regression of Minify CSS with Lightning CSS #25754 Before: After: |
@puni9869 Thanks for the reply. I did confirm that it works fine on gitea.com. @wxiaoguang Thank you for finding out the cause of the problem! |
If you need to follow the main branch, you can revert the #25754 in your build (it's quite small) and try. |
No hurry, if it is the case, I think there could still be some solutions:
|
I assume we could just the color to 6-digit format for Monaco if it only accepts that, there might be a function for it existing already. This should already be a problem with themes that use non-6-digit format. |
Monaco can not deal with color formats other than 6-digit hex, so we convert the colors for it via new [`tinycolor2`](https://github.com/bgrins/TinyColor) dependency (5kB minzipped). Also, with the addition of the module, we can replace the existing `hexToRGBColor` usage, I verified it is compatible with the current tests before removing the function. Fixes: #25770
Monaco can not deal with color formats other than 6-digit hex, so we convert the colors for it via new [`tinycolor2`](https://github.com/bgrins/TinyColor) dependency (5kB minzipped). Also, with the addition of the module, we can replace the existing `hexToRGBColor` usage, I verified it is compatible with the current tests before removing the function. Fixes: go-gitea#25770
Backport #25780, clean cherry-pick. Monaco can not deal with color formats other than 6-digit hex, so we convert the colors for it via new [`tinycolor2`](https://github.com/bgrins/TinyColor) dependency (5kB minzipped). Also, with the addition of the module, we can replace the existing `hexToRGBColor` usage, I verified it is compatible with the current tests before removing the function. Fixes: #25770
Description
When I try to create a new file or edit a file in the web editor, the web editor screen remains loading.
Reference.
This is not happening with version 1.19.3 that I am self-hosting.
Gitea Version
1.21.0+dev-254-g2ff0c12a9
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
No response
Operating System
No response
How are you running Gitea?
use https://try.gitea.io
Database
None
The text was updated successfully, but these errors were encountered: