Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch protection rules will not cancel old approvals after new commits submited #25858

Closed
Bisstocuz opened this issue Jul 13, 2023 · 0 comments · Fixed by #25882
Closed

branch protection rules will not cancel old approvals after new commits submited #25858

Bisstocuz opened this issue Jul 13, 2023 · 0 comments · Fixed by #25882
Labels
type/bug

Comments

@Bisstocuz
Copy link

Description

I set up branch protection rules half a month ago and checked the option "Dismiss stale pull request approvals when new commits are pushed", but this option did not take effect. Old approvals are not be canceled when there are new commits.

Gitea Version

1.19.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

2a2e706d9c7394a883459b63fe5a9160
cd06ce2e6bd41fdfd001c608ccba8bbd

Git Version

No response

Operating System

No response

How are you running Gitea?

docker compose

Database

MySQL
@lunny lunny mentioned this issue Jul 14, 2023
Merged
lunny added a commit that referenced this issue Jul 20, 2023
@lunny
Fix bug when pushing to a pull request which enabled dismiss approval…
01c0460 
… automatically (#25882)

Fix #25858 

The option `dissmiss stale approvals` was listed on protected branch but
never implemented. This PR fixes that.

<img width="1006" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/60bfa968-4db7-4c24-b8be-2e5978f91bb9">


<img width="1021" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/8dabc14d-2dfe-40c2-94ed-24fcbf6e0e8f">
lunny added a commit to lunny/gitea that referenced this issue Jul 26, 2023
@lunny
Fix bug when pushing to a pull request which enabled dismiss approval…
da5dd3c 
… automatically (go-gitea#25882)

Fix go-gitea#25858

The option `dissmiss stale approvals` was listed on protected branch but
never implemented. This PR fixes that.

<img width="1006" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/60bfa968-4db7-4c24-b8be-2e5978f91bb9">

<img width="1021" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/8dabc14d-2dfe-40c2-94ed-24fcbf6e0e8f">
@lunny lunny mentioned this issue Jul 26, 2023
Merged
lunny added a commit that referenced this issue Jul 27, 2023
@lunny
Fix bug when pushing to a pull request which enabled dismiss approval…
666038a 
… automatically (#25882) (#26158)

Fix #25858
Backport #25882 

The option `dissmiss stale approvals` was listed on protected branch but
never implemented. This PR fixes that.

<img width="1006" alt="图片"

src="https://github.com/go-gitea/gitea/assets/81045/60bfa968-4db7-4c24-b8be-2e5978f91bb9">

<img width="1021" alt="图片"

src="https://github.com/go-gitea/gitea/assets/81045/8dabc14d-2dfe-40c2-94ed-24fcbf6e0e8f">
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug when pushing to a pull request which enabled dismiss approval automatically lunny/gitea
1 participant
@Bisstocuz