Upgrade from 1.20.0-rc0 to 1.20.0 fails: Deprecated fallback present #25915

hkdd · 2023-07-16T22:55:37Z

Description

I just did a docker pull of :latest and docker-compose down/up the container and I get this. I was able to resolve by pinning it to 1.20.0-rc0 but 1.20.0-rc1 and rc2 failed as well as :latest which is currently 1.20.0.

Attaching to gitea_web
gitea_web | 2023/07/16 22:51:24 ...s/setting/setting.go:180:loadRunModeFrom() [F] Gitea is not supposed to be run a
s root. Sorry. If you need to use privileged TCP ports please instead use setcap and the cap_net_bind_service permission
gitea_web | Server listening on :: port 22.
gitea_web | Server listening on 0.0.0.0 port 22.
gitea_web | 2023/07/16 22:51:24 ...g/config_provider.go:327:deprecatedSettingFatal() [F] Deprecated fallback [serv er] LFS_CONTENT_PATH present. Use [lfs] PATH instead. This fallback will be/has been removed in v1.19.0
gitea_web | Received signal 15; terminating.
gitea_web | 2023/07/16 22:51:24 ...s/setting/setting.go:180:loadRunModeFrom() [F] Gitea is not supposed to be run a
s root. Sorry. If you need to use privileged TCP ports please instead use setcap and the cap_net_bind_service permission
gitea_web | Server listening on :: port 22.
gitea_web | Server listening on 0.0.0.0 port 22.
gitea_web | 2023/07/16 22:51:25 ...g/config_provider.go:327:deprecatedSettingFatal() [F] Deprecated fallback [serv er] LFS_CONTENT_PATH present. Use [lfs] PATH instead. This fallback will be/has been removed in v1.19.0
gitea_web | Received signal 15; terminating.
gitea_web | 2023/07/16 22:51:25 ...s/setting/setting.go:180:loadRunModeFrom() [F] Gitea is not supposed to be run a
s root. Sorry. If you need to use privileged TCP ports please instead use setcap and the cap_net_bind_service permission
gitea_web | Server listening on :: port 22.
gitea_web | Server listening on 0.0.0.0 port 22.
gitea_web | 2023/07/16 22:51:25 ...g/config_provider.go:327:deprecatedSettingFatal() [F] Deprecated fallback [serv er] LFS_CONTENT_PATH present. Use [lfs] PATH instead. This fallback will be/has been removed in v1.19.0
gitea_web | Received signal 15; terminating.
gitea_web | 2023/07/16 22:51:26 ...s/setting/setting.go:180:loadRunModeFrom() [F] Gitea is not supposed to be run a
s root. Sorry. If you need to use privileged TCP ports please instead use setcap and the cap_net_bind_service permission
gitea_web | Server listening on :: port 22.
gitea_web | Server listening on 0.0.0.0 port 22.
gitea_web | 2023/07/16 22:51:26 ...g/config_provider.go:327:deprecatedSettingFatal() [F] Deprecated fallback [serv er] LFS_CONTENT_PATH present. Use [lfs] PATH instead. This fallback will be/has been removed in v1.19.0
gitea_web | Received signal 15; terminating.

Gitea Version

1.20.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

1.20.0

Operating System

EL8

How are you running Gitea?

docker

Database

None

The text was updated successfully, but these errors were encountered:

delvh · 2023-07-16T22:58:50Z

The error message tells you explicitly what you need to do:

Deprecated fallback [server].LFS_CONTENT_PATH present. Use [lfs].PATH instead. This fallback has been removed in v1.19.0

So, go to your app.ini and change that.

Got the same problem as #25915 when updating an instance. The `log.Fatal` should have been marked as breaking in #23911. This PR adds a notice that the system is shutting down because of the deprecated setting.

Got the same problem as go-gitea#25915 when updating an instance. The `log.Fatal` should have been marked as breaking in go-gitea#23911. This PR adds a notice that the system is shutting down because of the deprecated setting.

@KN4CK3R

Backport #25920 by @KN4CK3R Got the same problem as #25915 when updating an instance. The `log.Fatal` should have been marked as breaking in #23911. This PR adds a notice that the system is shutting down because of the deprecated setting. Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

eallion · 2023-07-18T06:46:08Z

same

TWDickson · 2023-07-18T12:02:51Z

The error message tells you explicitly what you need to do:

Deprecated fallback [server].LFS_CONTENT_PATH present. Use [lfs].PATH instead. This fallback has been removed in v1.19.0

So, go to your app.ini and change that.

If you’re just using docker without any sort of config file how would you change it?

Edit: My /data directory exists on a docker volume and the image won't start due to this error, it's a pretty breaking change for users who had their configs from previous installations.

stoofz · 2023-07-18T17:07:42Z

Same issue as above in regards to updated Docker

x86dev · 2023-07-18T19:33:39Z

Just also reproduced this -- pulling the 1.20 container breaks, whereas pinning to 1.20.0-rc0 makes it work again. So something screwed up in the built container.

ternium1 · 2023-07-18T20:13:54Z

Having the same issue, did this to app.ini solved it:

Old app.ini:

[server]
APP_DATA_PATH=/data/gitea
...
LFS_START_SERVER=true
LFS_CONTENT_PATH=/data/git/lfs
LFS_JWT_SECRET=xxx

New app.ini:

[lfs]
PATH=/data/git/lfs


[server]
APP_DATA_PATH=/data/gitea
...
LFS_START_SERVER=true
LFS_JWT_SECRET=xxx

realies · 2023-07-19T16:19:45Z

what a weird change

x86dev · 2023-07-19T16:52:32Z

That fix does not work if you use the default container with no custom app.ini.

GhaziTriki · 2023-07-19T20:09:30Z

Working after deprecated configuration update.

hkdd · 2023-07-19T21:06:30Z

The error message tells you explicitly what you need to do:

Deprecated fallback [server].LFS_CONTENT_PATH present. Use [lfs].PATH instead. This fallback has been removed in v1.19.0

So, go to your app.ini and change that.

So for anyone else who runs into this, my solution was to just remove LFS_CONTENT_PATH. Creating a [lfs] ini header and a PATH variable doesn't resolve the problem. It will still fail because of the deprecated LFS_CONTENT_PATH, despite the alternative existing. So I ended up just removing the LFS_CONTENT_PATH line from the [server] section and was able to pull/run 1.20.0 successfully.

x86dev · 2023-07-19T21:15:52Z

The cause and the solution is clear, but the container image just isn't up-to-date ;-)

delvh · 2023-07-19T21:20:00Z

Yes. This warning is explicitly meant to notify admins that such config options no longer have any effect.
This prevents the situation that settings are no longer in effect that admins thought they set.
That's why this warning is crashing Gitea as intended when the setting is present.

After all, there are three ways to handle breaking config changes (that I see as viable):

Annoy admins slightly whenever they upgrade to fix their now outdated config to keep up to date
Carry old config options for quite a while and annoy admins a lot by removing all legacy options for several releases at once
Carry all old config options forever, and make the code effectively unmaintainable and unpredictable

Gitea currently chooses option 1..
I didn't go into detail about this error message previously in this issue as I thought my previous comment would suffice to let you know what happened, and how you can fix it.
Apparently I was wrong here. Sorry about that.

Regarding the Docker users:
If I've understood it correctly, there seems to be another issue in that the default Docker file comes with an app.ini that still sets a removed setting, right?
If that's the case, then that's a bug we should fix.

TWDickson · 2023-07-19T21:26:03Z

Regarding the Docker users:
If I've understood it correctly, there seems to be another issue in that the default Docker file comes with an app.ini that still sets a removed setting, right?
If that's the case, then that's a bug we should fix

That’s my exact scenario, my docker-compose has no app.ini supplied and the /data directory is just set to a docker volume.

delvh · 2023-07-19T21:27:27Z

What config option is breaking the docker container exactly?
I can't find [server].LFS_CONTENT_PATH inside https://github.com/go-gitea/gitea/blob/ad4c09b59f1657a5400c92913972e4cca578a4fb/docker/root/etc/templates/app.ini, and the last commit on this file indicated that the setting was renamed, and that commit was 18 months ago.

stoofz · 2023-07-19T22:42:41Z

Was able to update by rolling back to version 1.20.0-rc0 to be able to boot up the docker, then console in to edit the app.ini and added the [lfs] section and moving the PATH there while removing it from the [server] section. Now I am able to update and use the current docker image.

[lfs]
PATH=/data/git/lfs

[server]
APP_DATA_PATH=/data/gitea
...
LFS_START_SERVER=true
LFS_JWT_SECRET=xxx

KN4CK3R · 2023-07-20T05:35:14Z

You can edit the files in the volume even if the container is not running.

chascode · 2023-07-20T14:44:36Z

Does LFS_START_SERVER and LFS_JWT_SECRET still belong in the [server] section?

ternium1 · 2023-07-20T15:08:45Z

yes

timbze · 2023-07-25T15:04:40Z

What config option is breaking the docker container exactly? I can't find [server].LFS_CONTENT_PATH inside https://github.com/go-gitea/gitea/blob/ad4c09b59f1657a5400c92913972e4cca578a4fb/docker/root/etc/templates/app.ini, and the last commit on this file indicated that the setting was renamed, and that commit was 18 months ago.

The setting is there for containers that have been created before the setting was removed. I finally found /var/lib/docker/volumes/gitea_gitea/_data/gitea/conf/app.ini. I removed the setting and now I can start the container. (my last upgrade where it broke was from 1.19.0 to 1.20.1)

Peter-Hageman · 2023-07-26T08:45:31Z

changing app.ini didn't help. going back to 1.18.0 did :(

delvh · 2023-07-26T08:49:29Z

Why not?
Were there additional fatal warnings?
Or did you modify the wrong config file?

lunny · 2023-07-26T09:09:31Z

I think this could be closed since #26094 merged which will be in the following v1.20.2 after #26154 merge.

… file (#26094) (#26154) backport #26094 Temporily resolve #25915 Related #25994 This PR includes #26007 's changes but have a UI to prompt administrator about the deprecated settings as well as the log or console warning. Then users will have enough time to notice the problem and don't have surprise like before. <img width="1293" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/c33355f0-1ea7-4fb3-ad43-cd23cd15391d">

hkdd added the type/bug label Jul 16, 2023

delvh added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed type/bug labels Jul 16, 2023

delvh changed the title ~~Upgrade from 1.20.0-rc0 to 1.20.0 fails~~ Upgrade from 1.20.0-rc0 to 1.20.0 fails: Deprecated fallback present Jul 16, 2023

KN4CK3R mentioned this issue Jul 17, 2023

Add shutting down notice #25920

Merged

GiteaBot mentioned this issue Jul 17, 2023

Add shutting down notice (#25920) #25922

Merged

Mauladen mentioned this issue Jul 20, 2023

[BUG] Gitea won't start runtipi/runtipi#599

Closed

3 tasks

kchiem mentioned this issue Jul 23, 2023

Updated gitea plugin to 1.20.0, and the gitea service inside the jail fails to start ix-plugin-hub/iocage-plugin-index#374

Open

lunny mentioned this issue Jul 26, 2023

Display deprecated warning in admin panel pages as well as in the log file (#26094) #26154

Merged

Unrepentant-Atheist mentioned this issue Jul 28, 2023

Can't run docker container anymore. #26196

Closed

lunny closed this as completed Jul 29, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from 1.20.0-rc0 to 1.20.0 fails: Deprecated fallback present #25915

Upgrade from 1.20.0-rc0 to 1.20.0 fails: Deprecated fallback present #25915

hkdd commented Jul 16, 2023

delvh commented Jul 16, 2023

eallion commented Jul 18, 2023

TWDickson commented Jul 18, 2023 •

edited

Loading

stoofz commented Jul 18, 2023

x86dev commented Jul 18, 2023

ternium1 commented Jul 18, 2023

realies commented Jul 19, 2023

x86dev commented Jul 19, 2023

GhaziTriki commented Jul 19, 2023

hkdd commented Jul 19, 2023

x86dev commented Jul 19, 2023

delvh commented Jul 19, 2023

TWDickson commented Jul 19, 2023

delvh commented Jul 19, 2023

stoofz commented Jul 19, 2023 •

edited

Loading

KN4CK3R commented Jul 20, 2023

chascode commented Jul 20, 2023

ternium1 commented Jul 20, 2023 via email •

edited

Loading

timbze commented Jul 25, 2023 •

edited

Loading

Peter-Hageman commented Jul 26, 2023

delvh commented Jul 26, 2023

lunny commented Jul 26, 2023

Upgrade from 1.20.0-rc0 to 1.20.0 fails: Deprecated fallback present #25915

Upgrade from 1.20.0-rc0 to 1.20.0 fails: Deprecated fallback present #25915

Comments

hkdd commented Jul 16, 2023

Description

Gitea Version

Can you reproduce the bug on the Gitea demo site?

Log Gist

Screenshots

Git Version

Operating System

How are you running Gitea?

Database

delvh commented Jul 16, 2023

eallion commented Jul 18, 2023

TWDickson commented Jul 18, 2023 • edited Loading

stoofz commented Jul 18, 2023

x86dev commented Jul 18, 2023

ternium1 commented Jul 18, 2023

realies commented Jul 19, 2023

x86dev commented Jul 19, 2023

GhaziTriki commented Jul 19, 2023

hkdd commented Jul 19, 2023

x86dev commented Jul 19, 2023

delvh commented Jul 19, 2023

TWDickson commented Jul 19, 2023

delvh commented Jul 19, 2023

stoofz commented Jul 19, 2023 • edited Loading

KN4CK3R commented Jul 20, 2023

chascode commented Jul 20, 2023

ternium1 commented Jul 20, 2023 via email • edited Loading

timbze commented Jul 25, 2023 • edited Loading

Peter-Hageman commented Jul 26, 2023

delvh commented Jul 26, 2023

lunny commented Jul 26, 2023

TWDickson commented Jul 18, 2023 •

edited

Loading

stoofz commented Jul 19, 2023 •

edited

Loading

ternium1 commented Jul 20, 2023 via email •

edited

Loading

timbze commented Jul 25, 2023 •

edited

Loading