Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dublicate AppSubUrl in context_menu template #26060

Closed
ghost opened this issue Jul 22, 2023 · 0 comments · Fixed by #26066
Closed

Dublicate AppSubUrl in context_menu template #26060

ghost opened this issue Jul 22, 2023 · 0 comments · Fixed by #26066
Labels
type/bug

Comments

@ghost
Copy link

ghost commented Jul 22, 2023 •
edited by ghost
Loading

Description

"Copy Link" in templates/repo/issue/view_content/context_menu.tmpl is constructed this way: data-clipboard-text="{{AppSubUrl}}{{$referenceUrl}}". It seems that {{AppSubUrl}} is redundant:

  • $referenceUrl -> .ctxData.Issue.Link -> func (issue *Issue) Link() string
  • func (issue *Issue) Link() string-> fmt.Sprintf("%s/%s/%d", issue.Repo.Link(), path, issue.Index)
  • issue.Repo.Link() -> setting.AppSubURL + "/" + url.PathEscape(repo.OwnerName) + "/" + url.PathEscape(repo.Name)

As you can see there is already AppSubURL in referenceUrl so it looks like that it should be removed from the template.

Gitea Version

1.20

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

SQLite
@ghost ghost added the type/bug label Jul 22, 2023
@lunny lunny mentioned this issue Jul 23, 2023
Merged
KN4CK3R pushed a commit that referenced this issue Jul 23, 2023
@lunny
Fix duplicated url prefix on issue context menu (#26066)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
a12a5f3 
Fix #26060
@GiteaBot GiteaBot mentioned this issue Jul 23, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jul 23, 2023
@lunny @GiteaBot
Fix duplicated url prefix on issue context menu (go-gitea#26066)
48448fa 
Fix go-gitea#26060
KN4CK3R pushed a commit that referenced this issue Jul 23, 2023
@GiteaBot @lunny
Fix duplicated url prefix on issue context menu (#26066) (#26067)
ab4fd9a 
Backport #26066 by @lunny

Fix #26060

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@GiteaBot @earl-warren
Fix duplicated url prefix on issue context menu (go-gitea#26066) (go-…
99a4aba 
…gitea#26067)

Backport go-gitea#26066 by @lunny

Fix go-gitea#26060

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
(cherry picked from commit ab4fd9a)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix duplicated url prefix on issue context menu lunny/gitea
0 participants