Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix icon is broken (HTTP 404) on Matrix webhook page #26241

Closed
CodeShakingSheep opened this issue Jul 30, 2023 · 1 comment · Fixed by #26242
Closed

Matrix icon is broken (HTTP 404) on Matrix webhook page #26241

CodeShakingSheep opened this issue Jul 30, 2023 · 1 comment · Fixed by #26242
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@CodeShakingSheep
Copy link
Contributor

Description

When going to /user/settings/hooks/matrix/new to create a new webhook for Matrix the Matrix icon in the right top corner is broken. This is due to the matrix icon not being present under /assets/img/matrix.svg. I figured there is another matrix SVG file present here instead /assets/img/svg/gitea-matrix.svg. This could be referenced instead.

The issue is also reproducible on Gitea demo site. See here: https://try.gitea.io/user/settings/hooks/matrix/new

Screenshots

Screenshot from my Gitea instance:
image

Screenshot from browser console:
image

Gitea Version

1.20.1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows 10

Browser Version

Brave 1.56.14 (Chromium 115.0.5790.114)
@CodeShakingSheep CodeShakingSheep added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 30, 2023
@silverwind silverwind mentioned this issue Jul 30, 2023
Merged
@silverwind
Copy link
Member

#26242 will fix it and use a much-needed shared template.

silverwind added a commit to silverwind/gitea that referenced this issue Jul 30, 2023
@silverwind
Use shared template for webhook icons
3ed2ac2 
Fixes: go-gitea#26241
@GiteaBot GiteaBot mentioned this issue Jul 31, 2023
Merged
techknowlogick pushed a commit that referenced this issue Jul 31, 2023
@silverwind
Use shared template for webhook icons (#26242)
72363be 
Fixes: #26241
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jul 31, 2023
@silverwind @GiteaBot
Use shared template for webhook icons (go-gitea#26242)
fee0993 
Fixes: go-gitea#26241
silverwind added a commit that referenced this issue Jul 31, 2023
@GiteaBot @silverwind
Use shared template for webhook icons (#26242) (#26246)
2517da9 
Backport #26242 by @silverwind

Fixes: #26241

Co-authored-by: silverwind <me@silverwind.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use shared template for webhook icons silverwind/gitea
2 participants
@silverwind @CodeShakingSheep