Test failure: Race detected in TestGit/SSH

[silverwind]

Description

Seen this for the first time:

https://github.com/go-gitea/gitea/actions/runs/5808995595/job/15746928976?pr=26409

=== TestGit/SSH (tests/integration/git_test.go:95)
==================
WARNING: DATA RACE
Read at 0x00c00501a5b8 by goroutine 221160:
  github.com/gliderlabs/ssh.(*sshContext).Err()
      <autogenerated>:1 +0x31
  database/sql.(*Rows).awaitDone()
      /opt/hostedtoolcache/go/1.21.0/x64/src/database/sql/sql.go:2973 +0x2a8
  database/sql.(*Rows).initContextClose.func1()
      /opt/hostedtoolcache/go/1.21.0/x64/src/database/sql/sql.go:2949 +0x8f

Gitea Version

main

[silverwind]

Related: gliderlabs/ssh#211

[silverwind]

This is coming up a lot recently on CI. I wonder whether a recent change in our code exposed this race. Assuming upstream does not merge this quickly, we may need to put a bandaid fix in our code, or if possibly selectively disable the race detector for those code paths.

[wxiaoguang]

OK, I will "bypass" the upstream in the PR #26409

---

Update: The patch works, CI passes

[silverwind]

Fixed in main branch and 1.20, leaving it open until we have a proper fix via gliderlabs/ssh#211.

[wxiaoguang]

The upstream is dead. I think this issue could also be closed since our "workaround" works well.