Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST API does not return branch filter for #26591

Closed
jcollie opened this issue Aug 19, 2023 · 0 comments · Fixed by #26599
Closed

REST API does not return branch filter for #26591

jcollie opened this issue Aug 19, 2023 · 0 comments · Fixed by #26599
Labels
type/bug

Comments

@jcollie
Copy link

jcollie commented Aug 19, 2023

Description

As can be seen in the Swagger documentation for the repoListHooks and repoGetHook API calls, the branch filter is not returned when listing or getting webhooks.

https://try.gitea.io/api/swagger#/repository/repoListHooks
https://try.gitea.io/api/swagger#/repository/repoGetHook

It is possible to create or edit a webhook with a branch filter though.

https://try.gitea.io/api/swagger#/repository/repoCreateHook
https://try.gitea.io/api/swagger#/repository/repoEditHook

Gitea Version

1.20.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker

Database

PostgreSQL
@yardenshoham yardenshoham mentioned this issue Aug 19, 2023
Merged
silverwind pushed a commit that referenced this issue Aug 21, 2023
@yardenshoham @GiteaBot
Add branch_filter to hooks API endpoints (#26599)
16dee4f 
We now include the branch filler in the response.

- Closes #26591 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/73933940-c1a7-4573-abae-f340b63028b2)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/3b3c4a85-0f7c-48c7-8617-def7a66c671d)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot mentioned this issue Aug 21, 2023
Merged
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Aug 21, 2023
@yardenshoham @GiteaBot
Add branch_filter to hooks API endpoints (go-gitea#26599)
674e961 
We now include the branch filler in the response.

- Closes go-gitea#26591 

# Before

![image](https://github.com/go-gitea/gitea/assets/20454870/73933940-c1a7-4573-abae-f340b63028b2)

# After

![image](https://github.com/go-gitea/gitea/assets/20454870/3b3c4a85-0f7c-48c7-8617-def7a66c671d)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
wxiaoguang pushed a commit that referenced this issue Aug 21, 2023
@GiteaBot @yardenshoham
Add branch_filter to hooks API endpoints (#26599) (#26632)
fe78aab 
Backport #26599 by @yardenshoham

We now include the branch filler in the response.

- Closes #26591 

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add branch_filter to hooks API endpoints yardenshoham/gitea
1 participant
@jcollie