-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dark theme and default theme rename #27097
Comments
I was waiting for this proposal from long time. FInally the time has come. |
Too late for 1.21, I guess it will be 1.22. |
Wait, what's wrong with |
As I've understood it: Ultimately, I'm neutral about which design we choose as we will all be able to adapt to whatever is decided. |
There is at least these issue with current themes:
|
We can move arcgreen to a standalone repository so it can be used as external theme |
It would eventually require updates when color variables change, so I think we better kill it completely, or put it up somewhere in a "archived" state with no guarantees. |
While I personally use a dark theme, I'm in favour of keeping the light theme as default. While currently many sites on the Internet offers a dark theme, the most most will use the light theme as default, so Gitea should also do that. But maybe there's a way to respect |
|
) Part of #27097: - `gitea` theme is renamed to `gitea-light` - `arc-green` theme is renamed to `gitea-dark` - `auto` theme is renamed to `gitea-auto` I put both themes in separate CSS files, removing all colors from the base CSS. Existing users will be migrated to the new theme names. The dark theme recolor will follow in a separate PR. ##⚠️ BREAKING⚠️ 1. If there are existing custom themes with the names `gitea-light` or `gitea-dark`, rename them before this upgrade and update the `theme` column in the `user` table for each affected user. 2. The theme in `<html>` has moved from `class="theme-name"` to `data-theme="name"`, existing customizations that depend on should be updated. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
Got a initial draft here, but I don't like it yet as the secondary colors are too blue, the color shades are generated by this currently: const col = [0x13, 0x1d, 0x26];
for(let i = -3; i < 200; i += 1) {
const r = col[0] + i;
const g = col[1] + i + Math.floor(i / 32);
const b = col[2] + i + Math.floor(i / 16);
console.info(`#${r.toString(16)}${g.toString(16)}${b.toString(16)}`);
} |
another example theme https://code.plashenkov.com/plashenkov/gitea-theme-deep-dark |
Ideally I would like to use CSS color generation but the necessary CSS functionality is still too new to realistically use, maybe in a year or two: https://caniuse.com/mdn-css_types_color_color-mix |
👍 I put it more as a reference. It's all subjective - I think the background on plashenkov is too muted while the foreground on catppuccin is too bright. May be find a happy median. |
Now uses the same primary color as light theme. The secondary colors are shifted towards a slightly blue shade. Could maybe desaturate a bit more, but overall I think I'm happy with it. Fixes: #27097 <img width="1343" alt="Screenshot 2024-02-27 at 22 21 46" src="https://github.com/go-gitea/gitea/assets/115237/4163c393-b469-4a53-8f4b-1c33aa04f3ac"> <img width="581" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/e621f7f8-5679-4605-bf42-3d5ff1071e1e"> <img width="581" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/20e66493-2457-482b-b8f1-e5710934e189"> --------- Co-authored-by: Giteabot <teabot@gitea.io>
Now uses the same primary color as light theme. The secondary colors are shifted towards a slightly blue shade. Could maybe desaturate a bit more, but overall I think I'm happy with it. Fixes: go-gitea/gitea#27097 <img width="1343" alt="Screenshot 2024-02-27 at 22 21 46" src="https://github.com/go-gitea/gitea/assets/115237/4163c393-b469-4a53-8f4b-1c33aa04f3ac"> <img width="581" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/e621f7f8-5679-4605-bf42-3d5ff1071e1e"> <img width="581" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/20e66493-2457-482b-b8f1-e5710934e189"> --------- Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit d557fbc5a715a1920a2860cb04ae6c8fe2225182)
Feature Description
I think generally we agree that
arc-green
is a rather unconventional color theme and I don't like it very much. The idea is to make a new default dark theme with light blue primary color and almost-greyscale blue overall color. So I propose:gitea
theme togitea-light
and migrate existing usersarc-green
theme togitea-dark
and migrate existing usersThe colors I'd be aiming for are greyscale with a very subtle blue tint. Very similar to this blender theme and to Discord's dark theme, but not as blue as GitHub's dark theme.
Screenshots
The text was updated successfully, but these errors were encountered: