Subdir Support in Wiki

[snoweuph]

Feature Description

This Feature Request is about Support for Subdirectories in Gitea Wiki.
This Issue/Feature Request is inspired by: #823 and This Issue on Codeberg

As far as I understand, the Goal of this Request is included in #823, but because of the Other Things in that Feature-Request, its having Slow Progress.

Advantages

I think Support for Subdirectories is a Great Feature, because:

• It allows More Complex Structures, while keeping them Sorted
• It helps to bring structure into a Wiki
• It would work with a lot of Tools Out of the Box like: Obsidian and Logseq
• Its how most Bigger Wikis are Structured, Examples: Gitea Docs, Godot Wiki

What its About

This Feature Request is only about minimal needed subdir support, meaning:

• Files Can be Put in Subdirectories
• Files In Subdirectories can be normally Visited
• Files In Subdirectories can be normally Linked in Markdown to
• Subdirectories are shown in the Pages View.
• Files Renamed in Sudirs stays in them. (API support for Subdirs)
• / in File names is interpreted as Path/folder

Nice To Have

• Subdirectories are shown in the Pages View of the Wiki
• When changing / creating a wikipage-name, there's an info about Subdirectories and allowed characters, if there's an / in the name

Other Information

I am Interested in Contributing this Feature myself, so I'm also creating this Feature Request, to only have the Focus on the minimum I wish to Contribute, without having to worry about some Extra Features, which some might want, others not, and still need decision on how to be executed. (speaking bout #823)

[snoweuph]

I created a Fork, in which I will work on this: https://github.com/snoweuph/gitea

[snoweuph]

Okay, First Problem I was able to PinPoint is that:
wiki.go#findEntryFile calls tree_blob_nogogit.go#GetTreeEntryByPath, which prunes subdirs.

The Function GetTreeEntryByPathhas quite some calls, so It should probably be not modified.

Next step for me is to replace the call to that function with a custom Helper Function for testing, to find out, wich other things I might need to change

After I found all things I might need to change, im going to create a list of changes that I think need to do, and ask how to do them best

Edit: I think instead of a helper, I should modify the: wikiContentsByEntry Function (wiki.go)

[snoweuph]

Updating the loop in tree_blob_nogit.go like this, results in the Pages not throughing an Error, but I dont know if it has any other problems, that it brings with itselve.

for i, name := range parts {
	if i == len(parts)-1 {
		entries, err := tree.ListEntries()
		if err != nil {
			return nil, err
		}
		for _, v := range entries {
			if v.Name() == name {
+				if v.fullName == "" {
+					v.fullName = relpath
+				}
				return v, nil
			}
		}
	} else {
		tree, err = tree.SubTree(name)
		if err != nil {
			return nil, err
		}
	}
}

Renaming a site though with that change, results in the path beeing escaped, and the file moved by that.

[olivierlambert]

Hey there!

Also very interested by your work. Hopefully your PR will be merged soon 👍

[shamefulCake1]

Is there progress on this issue planned any time soon?

[bucovaina]

Also a gentle question if there is any planning around this issue, would be nice to have!

[snoweuph]

In a few Months I will have some time for contributing to FOSS again, but I wont contribute it here, but instead to the forgejo upstream, because I switched. Now that Go Git support is dropped, contributing this will be a lot easier.

[ilf]

@snoweuph: Thanks for creating this issue. Thanks for working on a solution. And thanks for the PR at #27900.
I don't understand why you closed this issue and marked it as completed?
It's okay to withdraw your PR. It's okay you want to stop contributing to this project.
But other people are interested in this issue in this project. Can't you just leave it open - for others?

[snoweuph]

No, because im the author and thus sadly cant unsubscribe, others that want it here can open up a new issue or follow to forgejo, when I've done it there

[snoweuph]

Simply now that forgejo switches from being downstream to its own project, I'm switching over as well with my PR issue, and my planned contribution list.

[snoweuph]

Sry, misread the part about closing as completed, looks like the android app didnt gave me the option to close as something specific, just to "close", corrected that and closed it as not planned. The reasons not to keep it open are described in the other messages