Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching commits gives error 500 #28575

Closed
BenGH28 opened this issue Dec 21, 2023 · 3 comments · Fixed by #28576
Closed

Searching commits gives error 500 #28575

BenGH28 opened this issue Dec 21, 2023 · 3 comments · Fixed by #28576
Labels
type/bug

Comments

@BenGH28
Copy link

BenGH28 commented Dec 21, 2023

Description

I have gitea in docker container with searching/indexing enabled. Upon searching the repo for a keyword I see an error 500 at the top of the page.

Gitea Version

1.21.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/BenGH28/4858551f7e9fa9c367168e73f6f5fe9e

Screenshots

image

Git Version

2.40.1

Operating System

Ubuntu

How are you running Gitea?

I'm running the docker image with docker version 20.10.7

Database

MySQL/MariaDB
@wxiaoguang wxiaoguang mentioned this issue Dec 21, 2023
Merged
@wxiaoguang
Copy link
Contributor

Sorry for the bug. -> Fix 500 error of searching commits #28576

lunny pushed a commit that referenced this issue Dec 21, 2023
@wxiaoguang
Fix 500 error of searching commits (#28576)
04b235d 
Regression of #28454 . Now the string is escaped HTML, so it doesn't
need `| Safe`.

Fix #28575
@GiteaBot GiteaBot mentioned this issue Dec 21, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 21, 2023
@wxiaoguang @GiteaBot
Fix 500 error of searching commits (go-gitea#28576)
38c8063 
Regression of go-gitea#28454 . Now the string is escaped HTML, so it doesn't
need `| Safe`.

Fix go-gitea#28575
@BenGH28
Copy link
Author

BenGH28 commented Dec 21, 2023

Thanks for fixing it👍

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 22, 2023 •
edited
Loading

The backport for 1.21 is

After the merge (soon...) and 1.21 branch finishes its CI work, you could use 1.21 nightly then 🙏

lafriks pushed a commit that referenced this issue Dec 22, 2023
@GiteaBot @wxiaoguang
Fix 500 error of searching commits (#28576) (#28579)
acc8100 
Backport #28576 by wxiaoguang

Regression of #28454 . Now the string is escaped HTML, so it doesn't
need `| Safe`.

Fix #28575

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@lunny lunny mentioned this issue Dec 22, 2023
Closed
techknowlogick pushed a commit to techknowlogick/gitea that referenced this issue Dec 23, 2023
@wxiaoguang @techknowlogick
Fix 500 error of searching commits (go-gitea#28576)
b488887 
Regression of go-gitea#28454 . Now the string is escaped HTML, so it doesn't
need `| Safe`.

Fix go-gitea#28575
@wxiaoguang wxiaoguang mentioned this issue Dec 24, 2023
Closed
uli-heller pushed a commit to uli-heller/gitea that referenced this issue Jan 16, 2024
@GiteaBot @wxiaoguang @uli-heller
Fix 500 error of searching commits (go-gitea#28576) (go-gitea#28579)
eec10ed 
Backport go-gitea#28576 by wxiaoguang

Regression of go-gitea#28454 . Now the string is escaped HTML, so it doesn't
need `| Safe`.

Fix go-gitea#28575

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@wxiaoguang @fuxiaohei
Fix 500 error of searching commits (go-gitea#28576)
0dd3c05 
Regression of go-gitea#28454 . Now the string is escaped HTML, so it doesn't
need `| Safe`.

Fix go-gitea#28575
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@wxiaoguang @silverwind
Fix 500 error of searching commits (go-gitea#28576)
de5f3f7 
Regression of go-gitea#28454 . Now the string is escaped HTML, so it doesn't
need `| Safe`.

Fix go-gitea#28575
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 500 error of searching commits wxiaoguang/gitea
2 participants
@wxiaoguang @BenGH28