Error when pasting an attachment

[CrowMash]

Description

In issues, when I paste a screenshot, the attachment does not appear:

But in the project view, I can see the image:

Looks like the URL in the image src does not contain the base URL (/gitea/ in my case):

Gitea Version

1.21.4 built with GNU Make 4.3, go1.21.5 : bindata, sqlite, sqlite_unlock_notify

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.30.2, Wire Protocol Version 2 Enabled

Operating System

debian 11

How are you running Gitea?

Installation from binary

Database

MySQL/MariaDB

[FrostKiwi]

I would like to confirm this on our setup as well. Hit us when upgrading from 1.21.1 to 1.21.4.

Issues' and PR's image links suddenly ignore the root URL, which is a subpath in our case. Our ROOT_URL is https://subdomain.example.com/git/
Images are still there and valid accessible in the attached files section, where they take on the form of https://subdomain.example.com/git/attachments/<hash>. As mentioned by @CrowMash, the project cards respect this Root path. However, in PRs and Issues they turn into https://subdomain.example.com/attachments/<hash>

A backup is present, but still, is it safe to downgrade to solve this temporarily?

edit: Since as per documentation, a change in the last digit 1.21.x does not constitute an update modifying something about the database, I downgraded to 1.21.1. Images work again.

[lunny]

Maybe related with #26745 @KN4CK3R

[KN4CK3R]

Don't really know if it's related. The comment content code is here:

gitea/routers/web/repo/issue.go

Lines 1620 to 1627 in 3084c99

	comment.RenderedContent, err = markdown.RenderString(&markup.RenderContext{
	Links: markup.Links{
	Base: ctx.Repo.RepoLink,
	},
	Metas: ctx.Repo.Repository.ComposeMetas(ctx),
	GitRepo: ctx.Repo.GitRepo,
	Ctx: ctx,
	}, comment.Content)

And the change I did is here:
https://github.com/go-gitea/gitea/pull/26745/files#diff-dc86301f15109eee38296d469630672193e0587ad1485fdd8f503bf4c789cf7eL1603

So, nothing really changed to the path, both use ctx.Repo.RepoLink. Maybe something is wrong with that but in that case much more should be broken.

[KN4CK3R]

Found it... This line converts /attachments to attachments which does not resolve to the root of the url. Looks more like a workaround...

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines