-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular loading spinner is an oval on mobile #29041
Comments
I've seen this on Gitea.com using the mobile safari browser. I can't replicate using a desktop browser even after changing viewport, so I'll have to figure out how to finally set up the remote developer console so I can see what happening. Edit: I've only seen this on the 2fa waiting/login screen |
I think I've managed to isolate the issue to the border properties. I created a codeine and started adding individual components of the gitea I made a little diagram of what is happening: Edit: here is the CSS that I put on the divs: div {
width: 40px;
height: 40px;
pointer-events: none !imoortant;
position: relative !important;
overflow: hidden !important;
} |
Fixes: go-gitea#29041 Fixes: go-gitea#29713 Any of the `width: *-content` properties seem to workaround this Webkit bug, this one seemed most suitable.
Backport #29801 by @silverwind Fixes: #29041 Fixes: #29713 Any of the `width: *-content` properties seem to workaround this Webkit bug, this one seemed most suitable. Before: <img width="184" alt="Screenshot 2024-03-14 at 22 29 58" src="https://github.com/go-gitea/gitea/assets/115237/6effc5f0-bc64-4752-be74-9c43b3974407"> After: <img width="177" alt="Screenshot 2024-03-14 at 22 30 30" src="https://github.com/go-gitea/gitea/assets/115237/5de244d7-6b46-428e-957c-4b10f53e2441"> Co-authored-by: silverwind <me@silverwind.io>
Fixes: go-gitea/gitea#29041 Fixes: go-gitea/gitea#29713 Any of the `width: *-content` properties seem to workaround this Webkit bug, this one seemed most suitable. (cherry picked from commit 35def319fdb8c73aa5e2c52fad5230d287e2bd93)
Backport #29801 by @silverwind Fixes: go-gitea/gitea#29041 Fixes: go-gitea/gitea#29713 Any of the `width: *-content` properties seem to workaround this Webkit bug, this one seemed most suitable. Before: <img width="184" alt="Screenshot 2024-03-14 at 22 29 58" src="https://github.com/go-gitea/gitea/assets/115237/6effc5f0-bc64-4752-be74-9c43b3974407"> After: <img width="177" alt="Screenshot 2024-03-14 at 22 30 30" src="https://github.com/go-gitea/gitea/assets/115237/5de244d7-6b46-428e-957c-4b10f53e2441"> Co-authored-by: silverwind <me@silverwind.io> (cherry picked from commit df23ec0f8b490bee49dc0e7944b529f3ede35301)
Description
When doing any operation that starts a loading spinner on mobile. It is always an oblong shape instead of a perfect circle. Most notably I see this when loading the user dashboard, logging in with passkey, or in any loading spinner.
Screenshots
Gitea Version
1.21.5
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
iOS 17.3
Browser Version
AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.3 Mobile/15E148 Safari/604.1
The text was updated successfully, but these errors were encountered: