Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong linenumber in search-result, when line is to long #29136

Closed
zokkis opened this issue Feb 11, 2024 · 3 comments · Fixed by #29260
Closed

Wrong linenumber in search-result, when line is to long #29136

zokkis opened this issue Feb 11, 2024 · 3 comments · Fixed by #29260
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.21.8

Comments

@zokkis
Copy link
Contributor

zokkis commented Feb 11, 2024

Description

When creating files with extra long lines, the text wraps and the linenumber is on the wrong line

Gitea Version

1.21.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image
Line 9 should be the line with "89485bfaa6a42365fbb052f9b34fc809e1bf6d3ed0c3b29376a22104030780c12"

Git Version

No response

Operating System

No response

How are you running Gitea?

Download and systemd

Database

SQLite
@yp05327
Copy link
Contributor

yp05327 commented Feb 15, 2024

Can you provide a sample?

@zokkis
Copy link
Contributor Author

zokkis commented Feb 15, 2024

Can you provide a sample?

There is a screenshot? What do you want more?

  • make a file with a long line
  • Search your repo for this line
  • see the result

@yp05327
Copy link
Contributor

yp05327 commented Feb 19, 2024

After several tries, successfully reproduced this issue.
image
image

@yp05327 yp05327 added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 19, 2024
@yp05327 yp05327 mentioned this issue Feb 19, 2024
Merged
@lunny lunny added this to the 1.21.8 milestone Mar 1, 2024
wxiaoguang added a commit that referenced this issue Mar 6, 2024
@yp05327 @wxiaoguang
Fix wrong line number in code search result (#29260)
a2b0fb1 
Fix #29136

Before: The result is a table and all line numbers are all in one row.

After: Use a separate table column for the line numbers.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot mentioned this issue Mar 6, 2024
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 6, 2024
@yp05327 @wxiaoguang @GiteaBot
Fix wrong line number in code search result (go-gitea#29260)
21e9f3c 
Fix go-gitea#29136

Before: The result is a table and all line numbers are all in one row.

After: Use a separate table column for the line numbers.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind pushed a commit that referenced this issue Mar 6, 2024
@GiteaBot @yp05327 @wxiaoguang
Fix wrong line number in code search result (#29260) (#29623)
9db426a 
Backport #29260 by @yp05327

Fix #29136

Before:
The result is a table and all line numbers are all in one row.

![image](https://github.com/go-gitea/gitea/assets/18380374/7a18b354-e257-4f57-a5ca-f6d37378edf6)

![image](https://github.com/go-gitea/gitea/assets/18380374/98416e11-89b5-4b4f-920b-91bcf041a87f)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/f189e436-9046-4431-926a-cd0deb58e8f1)

![image](https://github.com/go-gitea/gitea/assets/18380374/07d213ed-2401-4b7f-b951-5df7dc776af4)

~~Updated:~~
~~added `active` class to the target line.~~

![image](https://github.com/go-gitea/gitea/assets/18380374/0b274e48-048a-4c66-ba95-df515212ec08)

Co-authored-by: yp05327 <576951401@qq.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.21.8
Development

Successfully merging a pull request may close this issue.

Fix wrong line number in code search result yp05327/gitea
3 participants
@lunny @yp05327 @zokkis