Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] Workflows not triggered for PR assign and review #29166

Closed
clinche opened this issue Feb 14, 2024 · 3 comments · Fixed by #29173
Closed

[Actions] Workflows not triggered for PR assign and review #29166

clinche opened this issue Feb 14, 2024 · 3 comments · Fixed by #29173
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Milestone

Comments

@clinche
Copy link

clinche commented Feb 14, 2024

Description

I'm currently doing the setup of the CI/CD pipeline for our Gitea organization.
I'm writing two workflows that should be triggered by the following:

on:
  pull_request:
    types: [assigned, review_requested, labeled]

and

on:
  pull_request:
    types: [closed, unassigned, unlabeled, review_request_removed]

I didn't saw at the beginning that the review_requested* types are not supported by gitea, and this is okay.

However, the only events that currently trigger the workflow are labeled, unlabeled, and closed. From my understanding, assigned events should work but they trigger nothing.

What could be the causes? (and also, I probably should open another issue for this question but will review* types could be supported on workflows as they are handled by webhooks?)

I created a simple repo that can reproduce the issue here: the actions are launched for labeled and unlabeled but not for every other type trigger. EDIT: when the only label is removed, the called workflow is the one containing labeled, not unlabeled

Gitea Version

1.21.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I followed the docs on how to launch gitea using systemd, and the binary runs on bare-metal without any containerization

Database

PostgreSQL

@yp05327
Copy link
Contributor

yp05327 commented Feb 15, 2024

image
review requested was supported in #24481 which didn't add the support of detecting it in actions.
And for other hooks defined above should work. I will have a look of this issue.

@yp05327
Copy link
Contributor

yp05327 commented Feb 15, 2024

Actions notifier didn't implement IssueChangeAssignee event.
image
Also PullRequestReviewRequest is not implemented.
There is the list of all no-implemented functions:

image

@lunny lunny added this to the 1.21.6 milestone Feb 18, 2024
@lunny lunny added the topic/gitea-actions related to the actions of Gitea label Feb 18, 2024
@lunny lunny closed this as completed in 1a6e1cb Feb 18, 2024
yp05327 added a commit to yp05327/gitea that referenced this issue Feb 19, 2024
Backport go-gitea#29173

Fix go-gitea#29166

Add support for the following activity types of `pull_request`
- assigned
- unassigned
- review_requested
- review_request_removed
- milestoned
- demilestoned
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
Fix go-gitea#29166

Add support for the following activity types of `pull_request`
- assigned
- unassigned
- review_requested
- review_request_removed
- milestoned
- demilestoned
silverwind pushed a commit that referenced this issue Feb 22, 2024
Backport #29173

Fix #29166

Add support for the following activity types of `pull_request`
- assigned
- unassigned
- review_requested
- review_request_removed
- milestoned
- demilestoned
6543 pushed a commit to 6543-forks/gitea that referenced this issue Feb 26, 2024
Fix go-gitea#29166

Add support for the following activity types of `pull_request`
- assigned
- unassigned
- review_requested
- review_request_removed
- milestoned
- demilestoned

(cherry picked from commit 1a6e1cb)
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants