Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitea actions reference invalid link for Git tag #29731

Closed
tienthanh2509 opened this issue Mar 12, 2024 · 3 comments · Fixed by #29752
Closed

Gitea actions reference invalid link for Git tag #29731

tienthanh2509 opened this issue Mar 12, 2024 · 3 comments · Fixed by #29752
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@tienthanh2509
Copy link

Description

Gitea actions link to broken git tag
image

Actual
http://100.64.65.25:3000/xxxx/src/branch/v24.3.12

Expected
http://100.64.65.25:3000/xxxx/src/tag/v24.3.12

Gitea Version

1.21.7

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

UI bug

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

UI bug

Database

None
@lunny lunny added this to the 1.21.8 milestone Mar 12, 2024
@lunny
Copy link
Member

lunny commented Mar 12, 2024

Sorry, I cannot reproduce this both on main and release/v1.21

@lunny lunny added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Mar 12, 2024
@lunny lunny removed this from the 1.21.8 milestone Mar 12, 2024
@techknowlogick
Copy link
Member

Can you provide an example workflow you used? and steps to recreate this? Did you push a tag from the command lin, create the tag from the release page, or some other way?

@yp05327
Copy link
Contributor

yp05327 commented Mar 13, 2024

I can reproduce this issue, I will try to fix it.

ps: the trigger is

on: [create]

@yp05327 yp05327 added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Mar 13, 2024
@yp05327 yp05327 mentioned this issue Mar 13, 2024
Merged
lunny pushed a commit that referenced this issue Mar 19, 2024
@yp05327
Fix invalid link of the commit status when ref is tag (#29752)
98217b0 
Fix #29731
Caused by #24634
Also remove fixme.

ps: we can not fix the existed runs, as wrong refs are all recorded in
DB, and we can not know whether they are branch or tag:

![image](https://github.com/go-gitea/gitea/assets/18380374/cb7cf266-f73f-419a-be1a-4689fdd1952a)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid link of the commit status when ref is tag yp05327/gitea
4 participants
@lunny @techknowlogick @tienthanh2509 @yp05327