Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After deleting the review, the UI is broken. #29934

Closed
HEREYUA opened this issue Mar 20, 2024 · 2 comments · Fixed by #29935
Closed

After deleting the review, the UI is broken. #29934

HEREYUA opened this issue Mar 20, 2024 · 2 comments · Fixed by #29935
Labels
type/bug

Comments

@HEREYUA
Copy link
Contributor

HEREYUA commented Mar 20, 2024 •
edited
Loading

Description

Just as the title describes

before：

image

after：

image

Unsure if this is merely a display issue on the frontend, or if the review for the requested change should not have been deleted in the first place.

Gitea Version

Latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 20, 2024 •
edited
Loading

To reproduce:

  1. Start a pending review (code comment)
  2. "Request change" without comment
  3. Delete the code comment

@wxiaoguang wxiaoguang mentioned this issue Mar 20, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Fix comment review avatar alignment #29935

wxiaoguang added a commit that referenced this issue Mar 20, 2024
@wxiaoguang
Fix comment review avatar alignment (#29935)
bc55a80 
Fix #29934
silverwind pushed a commit to lunny/gitea that referenced this issue Mar 20, 2024
@wxiaoguang @silverwind
Fix comment review avatar alignment (go-gitea#29935)
5ec271b 
Fix go-gitea#29934
@wxiaoguang wxiaoguang mentioned this issue May 24, 2024
Open
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix comment review avatar alignment wxiaoguang/gitea
2 participants
@wxiaoguang @HEREYUA