Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The logos in the migration page are aligned to the left instead of center #30005

Closed
yardenshoham opened this issue Mar 22, 2024 · 2 comments · Fixed by #30007
Closed

The logos in the migration page are aligned to the left instead of center #30005

yardenshoham opened this issue Mar 22, 2024 · 2 comments · Fixed by #30007
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yardenshoham
Copy link
Member

Description

https://try.gitea.io/repo/migrate

Screenshots

image

Gitea Version

current main

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

.
@yardenshoham yardenshoham added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 22, 2024
@silverwind
Copy link
Member

Hmm, these should have tw-items-center but they have tw-content-center. This might be a regression from the tailwind migration.

@silverwind
Copy link
Member

Definitely an error from #29945.

@silverwind silverwind mentioned this issue Mar 22, 2024
Merged
silverwind added a commit that referenced this issue Mar 22, 2024
@silverwind
Fix incorrect tailwind migration (#30007)
04f9ad0 
Fixes #30005. Regression from
#29945.

There was only once instance of `tw-content-center` before that PR, so I
just ran below command and reverted that one instance.

```sh
perl -p -i -e 's#tw-content-center#tw-items-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
```
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 26, 2024
@silverwind @earl-warren
Fix incorrect tailwind migration (#30007)
3ea7437 
Fixes go-gitea/gitea#30005. Regression from
go-gitea/gitea#29945.

There was only once instance of `tw-content-center` before that PR, so I
just ran below command and reverted that one instance.

```sh
perl -p -i -e 's#tw-content-center#tw-items-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
```

(cherry picked from commit 04f9ad056882fc3f21b247b16f84437adf0f36d8)

Conflicts:
	templates/repo/diff/conversation.tmpl
	templates/repo/header.tmpl
	templates/repo/issue/filter_list.tmpl
	templates/repo/issue/view_content/conversation.tmpl
	templates/repo/wiki/view.tmpl
	web_src/js/components/DashboardRepoList.vue
	re-ran the command after discarding the Gitea changes to
	ensure all Forgejo files are also covered
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect tailwind migration silverwind/gitea
2 participants
@silverwind @yardenshoham