Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea does not apply CODEOWNERS for PRs from forks #30277

Closed
splitt3r opened this issue Apr 4, 2024 · 3 comments · Fixed by #30476
Closed

Gitea does not apply CODEOWNERS for PRs from forks #30277

splitt3r opened this issue Apr 4, 2024 · 3 comments · Fixed by #30476
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone

Comments

@splitt3r
Copy link
Contributor

splitt3r commented Apr 4, 2024

Description

If you create a pull request from a fork Gitea won't apply the CODEOWNERS. They only work for PRs from origin to origin.

Gitea Version

1.21.10

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

version: '3'

services:
  gitea:
    image: gitea/gitea
    container_name: gitea
    environment:
      - USER_UID=1000
      - USER_GID=1000
      - GITEA__database__DB_TYPE=postgres
      - GITEA__database__HOST=postgres:5432
      - GITEA__database__NAME=gitea
      - GITEA__database__USER=gitea
      - GITEA__database__PASSWD=gitea
      - GITEA__service__DEFAULT_KEEP_EMAIL_PRIVATE=false
    restart: always
    networks:
      - gitea
    volumes:
      - gitea-data:/data
      - /etc/timezone:/etc/timezone:ro
      - /etc/localtime:/etc/localtime:ro
    ports:
      - "3000:3000"
    depends_on:
      - postgres

  postgres:
    image: postgres
    container_name: postgres
    restart: always
    environment:
      - POSTGRES_USER=gitea
      - POSTGRES_PASSWORD=gitea
      - POSTGRES_DB=gitea
    networks:
      - gitea
    volumes:
      - postgres-data:/var/lib/postgresql/data

networks:
  gitea:

volumes:
  gitea-data:
  postgres-data:

Database

None

@lunny
Copy link
Member

lunny commented Apr 4, 2024

Did you mean your pull request is from fork to base repository? I think only pull requests from fork to fork have been disabled.

@lunny lunny added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 4, 2024
@splitt3r
Copy link
Contributor Author

splitt3r commented Apr 4, 2024

Did you mean your pull request is from fork to base repository?

Exactly

I think only pull requests from fork to fork have been disabled.

That makes sense

@lunny
Copy link
Member

lunny commented Apr 14, 2024

Caused by #29783 .

@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Apr 14, 2024
@lunny lunny added this to the 1.21.11 milestone Apr 14, 2024
silverwind pushed a commit that referenced this issue Apr 15, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Apr 15, 2024
lunny added a commit to lunny/gitea that referenced this issue Apr 15, 2024
silverwind pushed a commit that referenced this issue Apr 15, 2024
…a forked repository (#30476) (#30496)

Backport #30476 by @lunny

Fix #30277
Caused by #29783

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny added a commit that referenced this issue Apr 16, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants