Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code is not in middle of line in code preview #30353

Closed
yp05327 opened this issue Apr 9, 2024 · 0 comments · Fixed by #30372
Closed

Code is not in middle of line in code preview #30353

yp05327 opened this issue Apr 9, 2024 · 0 comments · Fixed by #30372
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.22.0

Comments

@yp05327
Copy link
Contributor

yp05327 commented Apr 9, 2024 •
edited
Loading

Description

image
image

maybe related #30298

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@yp05327 yp05327 added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 9, 2024
@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Apr 9, 2024
@silverwind silverwind mentioned this issue Apr 9, 2024
Merged
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 10, 2024
@lunny lunny added this to the 1.22.0 milestone Apr 10, 2024
lunny pushed a commit that referenced this issue Apr 10, 2024
@silverwind
Fix line height on inline code preview (#30372)
6cac11c 
Fixes #30353.

I don't know what causes `code-inner` to not inherit `line-height` from
its direct parent `.lines-code` but instead from grandparent `.markup`
even thought MDN tells me it's
[inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition).
This causes no negative impact on other code views, so I think it's the
best solution.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Apr 10, 2024
@silverwind @GiteaBot
Fix line height on inline code preview (go-gitea#30372)
b4d1cd3 
Fixes go-gitea#30353.

I don't know what causes `code-inner` to not inherit `line-height` from
its direct parent `.lines-code` but instead from grandparent `.markup`
even thought MDN tells me it's
[inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition).
This causes no negative impact on other code views, so I think it's the
best solution.
@GiteaBot GiteaBot mentioned this issue Apr 10, 2024
Merged
silverwind added a commit that referenced this issue Apr 10, 2024
@GiteaBot @silverwind
Fix line height on inline code preview (#30372) (#30385)
88b3d19 
Backport #30372 by @silverwind

Fixes #30353.

I don't know what causes `code-inner` to not inherit `line-height` from
its direct parent `.lines-code` but instead from grandparent `.markup`
even thought MDN tells me it's
[inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition).
This causes no negative impact on other code views, so I think it's the
best solution.

Co-authored-by: silverwind <me@silverwind.io>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 16, 2024
@silverwind @algernon
Fix line height on inline code preview (#30372)
12f7217 
Fixes go-gitea/gitea#30353.

I don't know what causes `code-inner` to not inherit `line-height` from
its direct parent `.lines-code` but instead from grandparent `.markup`
even thought MDN tells me it's
[inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition).
This causes no negative impact on other code views, so I think it's the
best solution.

(cherry picked from commit 6cac11cb1bc4b42bc7851a59b1f3a94700c5eb84)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 16, 2024
@GiteaBot @earl-warren
Fix line height on inline code preview (#30372) (#30385)
01129b5 
Backport #30372 by @silverwind

Fixes go-gitea/gitea#30353.

I don't know what causes `code-inner` to not inherit `line-height` from
its direct parent `.lines-code` but instead from grandparent `.markup`
even thought MDN tells me it's
[inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition).
This causes no negative impact on other code views, so I think it's the
best solution.

Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 88b3d192a0663bd5f25ffa07af45179bac755150)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Fix line height on inline code preview silverwind/gitea
3 participants
@lunny @silverwind @yp05327