Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Displaying of hex colors #3047

Closed
gsantner opened this issue Dec 1, 2017 · 4 comments · Fixed by #21474
Closed

[FR] Displaying of hex colors #3047

gsantner opened this issue Dec 1, 2017 · 4 comments · Fixed by #21474
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.18.0

Comments

@gsantner
Copy link

gsantner commented Dec 1, 2017 •
edited
Loading

  • Gitea version (or commit ref): v1.3.0

Description

GitHub added displaying of hex colors in rendered markdown some time ago, I just noticted it today. have to admit, to like it very much and find it useful, so suggesting it for gitea too. See screenshot below how it is visualized, or the referenced issue. I usually paste them in some color viewer, or guess colors, but having them directly shown is a really nice idea.

gsantner/markor#144

screenshot_2017-12-01__14-33_3
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 1, 2017
@lafriks lafriks added this to the 1.x.x milestone Dec 1, 2017
@stale
Copy link

stale bot commented Feb 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added issue/stale and removed issue/stale labels Feb 10, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 28, 2019
@sglux
Copy link

sglux commented Aug 19, 2021

Yes, indeed, this would be nice to have.
@lunny what does the label you added mean? It is since 2017 on milestone 1.x.x and we have 1.14.6 right now ;-)

@lunny
Copy link
Member

lunny commented Aug 19, 2021

That label will prevent stale bot mark it as stale. That means I think the issue should not be closed directly.

@gsantner
Copy link
Author

gsantner commented Sep 8, 2021 •
edited
Loading

this is how it looks nowadays on github:

grafik

@yardenshoham yardenshoham mentioned this issue Oct 16, 2022
Merged
lunny added a commit that referenced this issue Oct 21, 2022
@yardenshoham @KN4CK3R
@silverwind @lunny
Add color previews in markdown (#21474)
e828564 
* Resolves #3047

Every time a color code will be in \`backticks`, a cute little color
preview will pop up


[Inspiration](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#supported-color-models)

#### Before

![image](https://user-images.githubusercontent.com/20454870/196631524-298afbbf-d2c8-4018-92a5-0393a693d850.png)

#### After

![image](https://user-images.githubusercontent.com/20454870/196631397-36c561e4-08f5-465a-a36e-76084e30b08a.png)

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@delvh delvh modified the milestones: 1.x.x, 1.18.0 Oct 25, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Add color previews in markdown yardenshoham/gitea
5 participants
@lunny @lafriks @gsantner @sglux @delvh