Skip to content

"Clean up expired data" not working when hosting under a subpath #31285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d-danilov opened this issue Jun 7, 2024 · 1 comment · Fixed by #31289
Closed

"Clean up expired data" not working when hosting under a subpath #31285

d-danilov opened this issue Jun 7, 2024 · 1 comment · Fixed by #31289
Labels
type/bug

Comments

@d-danilov
Copy link

Description

When hosting under a subpath behind a reverse proxy (say, http://myserver.local/gitea as ROOT_URL), button "Clean up expired artifacts" in Site Administration->Code Assets->Packages (/admin/packages) does not work, resulting in a 404 instead.

The button POSTs to /admin/packages/cleanup, while expected to POST to /gitea/admin/packages/cleanup, where /gitea prefix is the subpath Gitea is being hosted on. If I manually add the subpath prefix to HTML via browser inspector, the button works, like this: <form method="post" action="/gitea/admin/packages/cleanup">

This seems to be due to missing usage of AppSubUrl here, like its used in other places.

Gitea Version

1.12.10

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Systemd

Database

None
@wxiaoguang wxiaoguang mentioned this issue Jun 7, 2024
Merged
@wxiaoguang
Copy link
Contributor

Fix some URLs whose sub-path is missing #31289

wxiaoguang added a commit that referenced this issue Jun 7, 2024
@wxiaoguang
Fix some URLs whose sub-path is missing (#31289)
0188d82 
Fix #31285
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jun 7, 2024
@wxiaoguang @GiteaBot
Fix some URLs whose sub-path is missing (go-gitea#31289)
dedac30 
Fix go-gitea#31285
@GiteaBot GiteaBot mentioned this issue Jun 7, 2024
Merged
wxiaoguang added a commit that referenced this issue Jun 7, 2024
@GiteaBot @wxiaoguang
Fix some URLs whose sub-path is missing (#31289) (#31292)
bbe98a3 
Backport #31289 by wxiaoguang

Fix #31285

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 5, 2024
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@wxiaoguang @earl-warren
Fix some URLs whose sub-path is missing (go-gitea#31289)
816e774 
Fix go-gitea#31285

(cherry picked from commit 0188d82)

Conflicts:
	templates/user/settings/applications.tmpl
(cherry picked from commit 3723d8c32059a571b84dc8636cb3649be6e6f1b3)

Conflicts:
	templates/user/settings/applications.tmpl
	trivial context conflict <i> vs <p>

(cherry picked from commit bbe98a3)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some URLs whose sub-path is missing wxiaoguang/gitea
2 participants
@wxiaoguang @d-danilov