Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian alphabet onlyin repo + org names #31345

Closed
icf20 opened this issue Jun 12, 2024 · 6 comments · Fixed by #32243
Closed

Italian alphabet onlyin repo + org names #31345

icf20 opened this issue Jun 12, 2024 · 6 comments · Fixed by #32243
Labels
type/enhancement An improvement of existing functionality

Comments

@icf20
Copy link

icf20 commented Jun 12, 2024

Description

Apparently repo and organizations names cant have

ñ, ç, ț, ă, â, ș, î

yes "Gobierno de España" the Spanish government is not allowed to be an organization

image

dont ask to have ñ->n, last time White House did that i went from feliz año to feliz ano

Gitea Version

1,22

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

container

Database

None

@icf20 icf20 added the type/bug label Jun 12, 2024
@silverwind
Copy link
Member

silverwind commented Jun 12, 2024

These name limitations are intentional to keep compatibilty with other forges like GitHub etc. See #4150 (comment) for some recent research on repo/org names. I guess it'd be fine to make this regex configurable but the default must stay compatible with other forges.

@delvh
Copy link
Member

delvh commented Jun 12, 2024

I guess it'd be fine to make this regex configurable

Not a good idea.
We cannot control what you write into the regex.
Why is not being able to validate it a bad idea?
Well… the org names must appear on your file system.
I have no idea how well OSs like Windows handle certain names.
Or even Linux, as special chars in a filename are always a good idea to annoy your server admin to no end.
And since we cannot validate the regex, this will lead to hard to understand error messages, and thus pissed off users.
So no, I'm not a fan of allowing non-ASCII chars.

@silverwind
Copy link
Member

Recent filesystems handle unicode pretty well, but still it's likely better to not let the user unknowingly break the portability of their repos.

@lunny
Copy link
Member

lunny commented Jun 13, 2024

I don't support relaxing the limitation except the git file system structure has been changed.

@lunny lunny added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed type/bug labels Jun 13, 2024
@denyskon
Copy link
Member

Maybe separate display names for repos could be an option.

@lunny
Copy link
Member

lunny commented Oct 11, 2024

Yes. Like the user has a Full Name, the organization also has a Full Name which is different from the login name. The problem is most places hasn't display that full name.

@lunny lunny added type/enhancement An improvement of existing functionality and removed issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea labels Oct 11, 2024
@lunny lunny closed this as completed in 896314c Nov 18, 2024
lunny added a commit that referenced this issue Nov 19, 2024
…32550)

Backport #32243 by @lunny

Partially fix #31345

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants