Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All pages show error JavaScript promise rejection: Cannot set properties of null (setting 'textContent'). #31675

Closed
wolfogre opened this issue Jul 23, 2024 · 0 comments · Fixed by #31676 or #31691
Closed

All pages show error JavaScript promise rejection: Cannot set properties of null (setting 'textContent'). #31675

wolfogre opened this issue Jul 23, 2024 · 0 comments · Fixed by #31676 or #31691
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI type/bug

Comments

@wolfogre
Copy link
Member

wolfogre commented Jul 23, 2024 •
edited
Loading

Description

image

How to reproduce

  1. Start Gitea WITHOUT a Secure contexts, like http://192.168.85.1:3000/
    • No https.
    • No 127.0.0.1, localhost, *.localhost
  2. Visit the sign-in page, and you will see a right warning about WebAuthn:
image
  1. And visit any other pages (even the home page), you will see:
image image

Possible causes

It seems introduced by

  1. After #31504, every page will run detectWebAuthnSupport
image
  1. And it emits error insecure
image
  1. But it's not sign-in page, it cannot get #webauthn-error-msg, so it shows a strange error.
image

Gitea Version

main (ad91a59)

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Command line.

Database

None
@wolfogre wolfogre added type/bug topic/ui Change the appearance of the Gitea UI issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Jul 23, 2024
@wolfogre wolfogre mentioned this issue Jul 23, 2024
Merged
@wolfogre wolfogre reopened this Jul 24, 2024
@wolfogre wolfogre mentioned this issue Jul 24, 2024
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
1 participant
@wolfogre