Add Passkey login support #31504
Merged
Add Passkey login support #31504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/go
|
Unrelated, but I see we need to increase contrast on these error message headers :) |
silverwind
added
the
type/feature
silverwind
reviewed
Jun 26, 2024
silverwind
reviewed
Jun 26, 2024
silverwind
reviewed
Jun 26, 2024
silverwind
reviewed
Jun 26, 2024
silverwind
reviewed
Jun 27, 2024
silverwind
approved these changes
Jun 27, 2024
GiteaBot
added
lgtm/need 1
Co-authored-by: silverwind <me@silverwind.io>
|
Thank you for your contributions. But I don't think the login UI is ideal. Maybe we can have a redesign because of Passkey login supported? |
Sure, I am open for suggestions. Using a link seemedd nice as it isn't to dominated compared to another button as not every system is supporting passkeys yet. Mainly orientated on Githubs approach (which seems pretty clean):
|
|
I think we could do the same and separate the links into a separate box. Moving the "Forget Password" besides the password label is also a good idea to make it look less crammed. I can help on these parts if you like. |
|
That sounds great. Feel free to push to this PR. |
|
I will. Another change I plan is to make the "Sign In" button full width. It'll look better, be easier to click and match the OAuth buttons as well. |
delvh
approved these changes
Jun 28, 2024
GiteaBot
added
lgtm/done
|
@silverwind Did some testing:
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 1, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix markdown preview $$ support (go-gitea#31514) Add Passkey login support (go-gitea#31504) Use stable version of fabric (go-gitea#31526) Always use HTML attributes for avatar size (go-gitea#31509) Add initial typescript config and use it for eslint,vitest,playwright (go-gitea#31186) Support legacy _links LFS batch responses (go-gitea#31513) Fix JS error with disabled attachment and easymde (go-gitea#31511)
lafriks
pushed a commit
that referenced
this pull request
Jul 5, 2024
As requested in #31504 (comment). This PR refactor the login page:    # Changes - [x] use separate box for passkey login and go to registration - [x] move forgot passoword next to password label - [x] fix password required label `*` and padding - [x] remove tabs from login page --------- Co-authored-by: silverwind <me@silverwind.io>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Jul 10, 2024
As requested in go-gitea/gitea#31504 (comment). This PR refactor the login page:    - [x] use separate box for passkey login and go to registration - [x] move forgot passoword next to password label - [x] fix password required label `*` and padding - [x] remove tabs from login page --------- Co-authored-by: silverwind <me@silverwind.io> (cherry picked from commit 9c00dda33ad7bd594dd8f331fa1bf0acefc2ca54) Conflict resolution: * signin_navbar.tmpl has been deleted * additions in form.css * major code changes in signin_openid * ...
This was referenced Jul 23, 2024
lafriks
pushed a commit
that referenced
this pull request
Jul 25, 2024
Follow #31676, which is not correct, see #31676 (comment) Fix #31675, regression of #31504.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22015
After adding a passkey, you can now simply login with it directly by clicking
Sign in with a passkey.Note for testing. You need to run gitea using
httpsto get the full passkeys experience.