Artifacts get lost, when re-running old workflows

[hakito]

Description

I just tried to re-run a job that was executed 2 weeks ago. We have set ARTIFACT_RETENTION_DAYS = 7 in the actions section.

The build job actually says that artifact upload is succesful. But the next job, that tries to fetch the artifact fails:

Total number of files that will be downloaded: 540
A 500 response code has been received while attempting to download an artifact
Exponential backoff for retry #1. Waiting for 5[4](https://HIDDEN/actions/runs/860/jobs/1#jobstep-1-4)75 milliseconds before continuing the download
A 500 response code has been received while attempting to download an artifact
Exponential backoff for retry #1. Waiting for [5](https://HIDDEN/actions/runs/860/jobs/1#jobstep-1-5)482 milliseconds before continuing the download

I also tried downloading the artifact manually and get the error:

artifact not found

I also tried to delete the artifact manually in the web interface. This also returns a 200 code for the DELETE request. However the artifact does not disappear.

Here a part of the response from the artifacts GET request after the deletion attempt:

{
    "artifacts": [
        {
            "name": "Bin.Unprotected",
            "size": 80032963,
            "status": "expired"
        }
    ]
}

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

MySQL/MariaDB

[Zettat123]

We should improve the CreateArtifact function to support updating uploaded artifacts when re-running a job.

gitea/models/actions/artifact.go

Lines 57 to 82 in 5242e52

	func CreateArtifact(ctx context.Context, t *ActionTask, artifactName, artifactPath string, expiredDays int64) (*ActionArtifact, error) {
	if err := t.LoadJob(ctx); err != nil {
	return nil, err
	}
	artifact, err := getArtifactByNameAndPath(ctx, t.Job.RunID, artifactName, artifactPath)
	if errors.Is(err, util.ErrNotExist) {
	artifact := &ActionArtifact{
	ArtifactName: artifactName,
	ArtifactPath: artifactPath,
	RunID: t.Job.RunID,
	RunnerID: t.RunnerID,
	RepoID: t.RepoID,
	OwnerID: t.OwnerID,
	CommitSHA: t.CommitSHA,
	Status: int64(ArtifactStatusUploadPending),
	ExpiredUnix: timeutil.TimeStamp(time.Now().Unix() + 3600*24*expiredDays),
	}
	if _, err := db.GetEngine(ctx).Insert(artifact); err != nil {
	return nil, err
	}
	return artifact, nil
	} else if err != nil {
	return nil, err
	}
	return artifact, nil
	}