Skip to content

Review comment's avatars are not aligned #33017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lunny opened this issue Dec 28, 2024 · 0 comments · Fixed by #33031
Closed

Review comment's avatars are not aligned #33017

lunny opened this issue Dec 28, 2024 · 0 comments · Fixed by #33031
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@lunny
Copy link
Member

lunny commented Dec 28, 2024 •
edited
Loading

The avatar should be on the left side of the chat icon like other comments but not.

https://gitea.com/gitea/docs/pulls/131

图片
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Dec 28, 2024
@henrygoodman henrygoodman mentioned this issue Dec 29, 2024
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 29, 2024
@henrygoodman @wxiaoguang @GiteaBot
Fix review code comment avatar alignment (go-gitea#33031)
b84ab0d 
Fixes go-gitea#33017

Avatar should only have offset if the `Comment` has `Content` or
`Attachment` to align with the speech bubble.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot mentioned this issue Dec 29, 2024
Merged
wxiaoguang added a commit that referenced this issue Dec 29, 2024
@GiteaBot @henrygoodman @wxiaoguang
Fix review code comment avatar alignment (#33031) (#33032)
7f0050c 
Backport #33031 by henrygoodman

Fixes #33017

Co-authored-by: Henry Goodman <79623665+henrygoodman@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix review code comment avatar alignment henrygoodman/gitea
1 participant
@lunny