Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release build misses -s -w flag #33030

Closed
wxiaoguang opened this issue Dec 29, 2024 · 1 comment · Fixed by #33041
Closed

Release build misses -s -w flag #33030

wxiaoguang opened this issue Dec 29, 2024 · 1 comment · Fixed by #33041
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Comments

@wxiaoguang
Copy link
Contributor

@techknowlogick

$(EXECUTABLE): $(GO_SOURCES) $(TAGS_PREREQ)
	CGO_CFLAGS="$(CGO_CFLAGS)" $(GO) build $(GOFLAGS) $(EXTRA_GOFLAGS) -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' -o $@

.PHONY: release-linux
release-linux: | $(DIST_DIRS)
	CGO_CFLAGS="$(CGO_CFLAGS)" $(GO) run $(XGO_PACKAGE) -go $(XGO_VERSION) -dest $(DIST)/binaries -tags 'netgo osusergo $(TAGS)' -ldflags '-linkmode external -extldflags "-static" $(LDFLAGS)' -targets '$(LINUX_ARCHS)' -out gitea-$(VERSION) .
@wxiaoguang wxiaoguang mentioned this issue Dec 29, 2024
Closed
@techknowlogick techknowlogick mentioned this issue Dec 30, 2024
Merged
@techknowlogick
Copy link
Member

thanks. I've just created #33041 and I've included those flags for the windows, darwin, and freebsd releases too.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Dec 30, 2024
@lunny lunny closed this as completed in 232867c Dec 30, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 30, 2024
@techknowlogick @GiteaBot
use -s -w ldflags for release artifacts (go-gitea#33041)
d3221e1 
fix go-gitea#33030
@GiteaBot GiteaBot mentioned this issue Dec 30, 2024
Merged
lunny pushed a commit that referenced this issue Dec 30, 2024
@GiteaBot @techknowlogick
use -s -w ldflags for release artifacts (#33041) (#33042)
0858a36 
Backport #33041 by @techknowlogick

fix #33030

Co-authored-by: techknowlogick <techknowlogick@gitea.com>
@wxiaoguang wxiaoguang reopened this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use -s -w ldflags for release artifacts techknowlogick/gitea
3 participants
@lunny @techknowlogick @wxiaoguang