Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passkey login persists after disabling login form #33314

Closed
mitsimi opened this issue Jan 17, 2025 · 1 comment · Fixed by #33348
Closed

passkey login persists after disabling login form #33314

mitsimi opened this issue Jan 17, 2025 · 1 comment · Fixed by #33348
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.24.0

Comments

@mitsimi
Copy link

mitsimi commented Jan 17, 2025

Description

We’ve disabled the login form in app.ini by setting ENABLE_BASIC_AUTHENTICATION=false and ENABLE_PASSWORD_SIGNIN_FORM=false. This is because we use an external auth server. However, the passkey login option persists.

Gitea Version

1.23.1 built with GNU Make 4.4.1, go1.23.4 : bindata, timetzdata, sqlite, sqlite_unlock_notify

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Image

Git Version

2.47.1

Operating System

No response

How are you running Gitea?

docker

Database

None
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. and removed type/bug labels Jan 17, 2025
@lunny
Copy link
Member

lunny commented Jan 17, 2025

I think this is a proposal optional to disable passkey login.

@yp05327 yp05327 mentioned this issue Jan 22, 2025
Merged
@lunny lunny added this to the 1.24.0 milestone Jan 22, 2025
wxiaoguang added a commit to wxiaoguang/gitea that referenced this issue Mar 7, 2025
@yp05327 @wxiaoguang
Support disable passkey auth (go-gitea#33348)
a44c7b6 
Fix go-gitea#33314

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang mentioned this issue Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Support disable passkey auth yp05327/gitea
2 participants
@lunny @mitsimi