The issue reply citation requires an additional line break

[seepine]

Feature Description

It would be preferable if quoted replies could automatically append a line break (like GitHub), as currently any comment typed after a quoted reply gets incorrectly included in the quoted content.

Screenshots

Github

Gitea

[wxiaoguang]

It should be easy to fix, if someone has time 😄

[lukasfischer1998]

I'm not yet very familiar with the workflow for collaboration - how can I take on an issue? I would like to make a pr for that issue? @wxiaoguang

[wxiaoguang]

If I remember correctly, the related code is here:

gitea/web_src/js/features/repo-issue-edit.ts

Lines 146 to 150 in d725b78

	if (editor.value()) {
	editor.value(`${editor.value()}\n\n${quotedContent}`);
	} else {
	editor.value(quotedContent);
	}

And don't worry, if it's not easy (actually the workflow is not that easy 😄 ), I could also fix if I get some time.

[khs-alt]

Hi! I’d love to work on this issue. Would it be okay if I gave it a try? @wxiaoguang

[wxiaoguang]

Hi! I’d love to work on this issue. Would it be okay if I gave it a try?

Welcome! Feel free to take a try.

[khs-alt]

Dear @wxiaoguang I’ve pushed a fix for this issue

Problem

When clicking the "Quote reply" button, only a single line break (\n) was added after the quoted content.
As a result, the user's reply appeared to be part of the quote block when rendered in Markdown.

Solution

I updated the quote insertion logic so that it adds one more line break (\n) work like Github
This way, the cursor lands on a new line and the user's reply is no longer interpreted as part of the quote.

Modified code

gitea/web_src/js/features/repo-issue-edit.ts 134~135

  if (!contentToQuote) contentToQuote = targetRawToQuote.textContent;
  const quotedContent = `${contentToQuote.replace(/^/mg, '> ')}\n\n`; <- add one more '\n'

Before

After

I just finished testing. Would it be okay if I opened a PR for this?

[wxiaoguang]

I just finished testing. Would it be okay if I opened a PR for this?

Welcome to do so.