Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentioning should check if the user exists #3444

Closed
1 task done
kolaente opened this issue Feb 1, 2018 · 1 comment · Fixed by #21533
Closed
1 task done

Mentioning should check if the user exists #3444

kolaente opened this issue Feb 1, 2018 · 1 comment · Fixed by #21533
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@kolaente
Copy link
Member

kolaente commented Feb 1, 2018

  • Gitea version (or commit ref): 1.4.0-rc1
  • Can you reproduce the bug at https://try.gitea.io:
    • Probably

Description

When mentioning someone in an issue or pr, it doesn't seem to matter if the user exists or not. For example, when I mention someone @NonexistentUser, Gitea still creates a link from it, leading to a 404 page. It shold check if the user exists and only create the link if it does.
@lafriks lafriks added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 1, 2018
@bkcsoft
Copy link
Member

bkcsoft commented Feb 10, 2018

If someone implements this, cache the result for at least that page-view :trollface:

@yardenshoham yardenshoham mentioned this issue Oct 21, 2022
Merged
wxiaoguang added a commit that referenced this issue Oct 22, 2022
@yardenshoham @wxiaoguang @lunny
Add link to user profile in markdown mention only if user exists (#21533
63ebb53 
)

Previously mentioning a user would link to its profile, regardless of
whether the user existed. This change tests if the user exists and only
if it does - a link to its profile is added.

* Fixes #3444

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add link to user profile in markdown mention only if user exists yardenshoham/gitea
3 participants
@lafriks @bkcsoft @kolaente