`upgrade.sh` exits with error if Gitea is already the latest version

[eric-j-ason]

Description

If everything goes fine, and upgrade.sh concludes that the running version of Gitea already is the latest, it exits with status 1, as if there was an error. It would be as if apt upgrade exited with status 1 whenever all packages were already up to date.

gitea/contrib/upgrade.sh

Line 88 in 57b8441

[[ "$current" == "$giteaversion" ]] && echo "$current is already installed, stopping." && exit 1

I suggest exiting with status 0 in this situation.

Gitea Version

57b8441

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Downloading and running https://github.com/go-gitea/gitea/blob/main/contrib/upgrade.sh.

Database

None

[silverwind]

I agree, no upgrade available is not a failure.

[eric-j-ason]

I'll just go ahead and make a pull request, that whoever is in charge can accept or reject.

By the way, I notice that the introduction of strict mode (set -euo pipefail) sits halfway through the file. It used to be at the top, which is probably its right place.

gitea/contrib/upgrade.sh

Line 61 in 463016b

set -euo pipefail

[silverwind]

Maybe its because some commands before can fail and we don't want the script to exit because of set -e. If there are failing commands, wrap them in a set +e and set -e to temporarily allow command failures.