Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow merging until the CI bot reports about success build #3588

Closed
iddm opened this issue Feb 26, 2018 · 6 comments · Fixed by #7481
Closed

Disallow merging until the CI bot reports about success build #3588

iddm opened this issue Feb 26, 2018 · 6 comments · Fixed by #7481
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@iddm
Copy link
Contributor

iddm commented Feb 26, 2018

This is supported for the github and travis CI, for example. So, using a github and travis CI you may configure it so that it is impossible to merge the pull requests before the CI bot allows you.

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 26, 2018
@iddm
Copy link
Contributor Author

iddm commented Oct 28, 2018

Are there any estimations on this? Could we put a milestone on it? Do you guys have some discussions regarding issues, which goes where, for example? :)

@lunny
Copy link
Member

lunny commented Oct 29, 2018

This should be an option on branch protected I think.

@stale
Copy link

stale bot commented Jan 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 5, 2019
@NicolasPetton
Copy link

Any update on this issue? I'd love to have something like this in gitea.

@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 30, 2019
@stale stale bot removed the issue/stale label Jan 30, 2019
@lafriks
Copy link
Member

lafriks commented Jan 30, 2019

@NicolasPetton noone is working on this currently

@japettyjohn
Copy link

Besides the integration with the pull request process itself, the merge requirement seems it could be met by adding to the required approvals a list of users/teams required in combination with the existing "number of required approvals" currently implemented.

@lunny lunny modified the milestones: 1.x.x, 1.10.0 Sep 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants