Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Multiarchitecture build for Docker Container #3633

Closed
whatever4711 opened this issue Mar 6, 2018 · 2 comments
Closed

Enable Multiarchitecture build for Docker Container #3633

whatever4711 opened this issue Mar 6, 2018 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@whatever4711
Copy link

whatever4711 commented Mar 6, 2018

Hi together,

let me suggest a new structure for your build:
It would be great if Docker builds are separated from the source repository.

For Docker I already setup a multiarchitecture repository whatever4711/docker-gitea, which builds Containers for amd64, i386, arm64, and arm32 with the same basic Dockerfile on CircleCI. Additionally, it tags those images accordingly, such that the call docker run -it -p 2222:22 -p 3000:3000 whatever4711/gitea downloads the version for your system and there is no need for several Dockerhub repositories anymore.

Referencing issue #2607 and PR #2927

Best regards

@lafriks lafriks added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Mar 7, 2018
@sapk
Copy link
Member

sapk commented Mar 12, 2018

In previous PR related to docker (at least #1985), I try to setup to allow that and making a sub makefile under docker folder. That way we could keep it inside gitea repo. The direction that was taken was to keep gitea directly related stuff, like documentation, inside the same repo.
As for multi-arch, now that docker cli will support it natively we should wait for it to become stable. I previously make using the earliest github.com/estesp/manifest-tool (#1615) but split into multiple step to ease the process of reviewing as not all maintainers use docker. We could definitly improve my first try with your code for multi-arch image.

@sapk
Copy link
Member

sapk commented Jan 16, 2020

I think we can close this as we provide multi-arch image now. We only build them for linux/amd64 and arm64 but the base is done. There is other issues to track missing platform like arm32 for rpi.
Feel free to re-open if needed.

@sapk sapk closed this as completed Jan 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants