Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant delete a realease without deleting a tag #378

Closed
couling opened this issue Dec 12, 2016 · 5 comments · Fixed by #546
Closed

Cant delete a realease without deleting a tag #378

couling opened this issue Dec 12, 2016 · 5 comments · Fixed by #546
Labels
Milestone

Comments

@couling
Copy link
Contributor

couling commented Dec 12, 2016

There is a strong connection between tags and releases in Gitea. When you create a release gitea also creates a tag if the tag name doesn't already exist. When you delete a release it also deletes the tag.

This has two main flaws:

  • It's easy to create a tag when you intended to reuse one (or visa versa).
  • It's impossible to delete a release without deleting the tag.

Suggested enhancements to resolve this:

  • Option to not delete a tag while deleting release
  • Indication on create release screen to show when an existing tag is being used
  • Link from releases screen to change a regular tag into a release
@couling couling changed the title Cant delete a realise without deleting a tag Cant delete a realease without deleting a tag Dec 12, 2016
@tboerger tboerger added this to the 1.1.0 milestone Dec 12, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 12, 2016

@tboerger more of a feature/enhancement right?

@couling
Copy link
Contributor Author

couling commented Dec 13, 2016

I'd say 90% Feature, 10% Bug.

The bug element is that, it seems wrong to be left with no tag after the following:

  1. Add tag in git
  2. Create release in Gitea
  3. Delete Gitea

That is to say that creating and deleting a release shouldn't delete a pre-existing tag. I'm sure there are some who would argue "working as designed" though.

@tboerger
Copy link
Member

@bkcsoft bug and feature at the same time, at least in my opinion.

@tboerger
Copy link
Member

A release is bound to a tag, but a tag can also totally fine exist without a release

@lunny
Copy link
Member

lunny commented Dec 27, 2016

So we can simply don't delete the tag when deleting a release! Tags could be delete via git or Gitea API, so that we could not provide ui to delete it currently.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants