Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default action when deleting a release to not delete tag #546

Merged
merged 1 commit into from
Jan 3, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 31, 2016

This will resolve #378. After delete a release, you also delete a tag via git command.

@lunny lunny added the type/bug label Dec 31, 2016
@lunny lunny added this to the 1.1.0 milestone Dec 31, 2016
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 31, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Jan 3, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 3, 2017
@bkcsoft bkcsoft merged commit 3c71163 into go-gitea:master Jan 3, 2017
@tboerger
Copy link
Member

tboerger commented Jan 4, 2017

Backport to 1.0.1?

@tboerger tboerger added the backport/done All backports for this PR have been created label Jan 5, 2017
@lunny lunny deleted the lunny/del_release_not_del_tag branch April 19, 2017 05:41
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant delete a realease without deleting a tag
4 participants