Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap: an error is logged when a user is not an admin #3849

Closed
2 of 7 tasks
junkb opened this issue Apr 26, 2018 · 0 comments · Fixed by #5771
Closed
2 of 7 tasks

ldap: an error is logged when a user is not an admin #3849

junkb opened this issue Apr 26, 2018 · 0 comments · Fixed by #5771
Labels

Comments

@junkb
Copy link

junkb commented Apr 26, 2018

Description

when the ldap search is performed to determine if a user is an admin, if there is no result [meaning the user in question is not an admin], an error is logged. this is a little misleading - if there is no result, because the user is not in the admin group, then things are working exactly as they should, and there is no error. i think it would be helpful if this outcome were handled and logged differently than an error

@junkb junkb changed the title an error is logged when the ldap admin search filter returns no results [ldap] an error is logged when a user is not an admin Apr 26, 2018
@junkb junkb changed the title [ldap] an error is logged when a user is not an admin ldap: an error is logged when a user is not an admin Apr 26, 2018
HarshitOnGitHub added a commit to HarshitOnGitHub/gitea that referenced this issue Jan 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants