Disallow merging if PR has been rejected

[FryDay]

If you request changes on a PR, you are still able to merge it. Github disallows merging if a PR is rejected.

[lafriks]

Was not there issue already about this?

[FryDay]

Not that I was able to find.

[lunny]

@FryDay I think a PR is rejected by someone could still be merged on Github.

[FryDay]

Only someone with admin privileges, and you need to click through warnings to do it.

[lunny]

@FryDay yes, we could follow that.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.

[3l73]

AFAIK the reject information stored inside of a review, that is connected to a comment.

In order to disable a pull request, all comments of an issue have to be process, checking if the rejection is still valid.
This solution become a problem depending on the amount of comments.

One possible solution could be changing the relation between comment and review to issue and review.
This solution could lead to

1. a better runtime (less entries inside a loop)
2. a listing who reject a pull request
   • this could be used to remove reject status by an administrator
3. possibility to create a rule that a review is required in order to merge

[3l73]

Based on the solution described in the previous comment, there is a way with less refactoring.

The issue is extended with the review, the review remain inside the comment.
The issue indexer process the comments and create the review inside the issue based on the information inside the comment.

Did not know how often the indexer is running and how long it will take to process the data.

[3l73]

I will have a look inside this issue.

Other issues going in the same direction:

• Disallow merging until the CI bot reports about success build #3588
• Better CI Integration #996

[lunny]

duplicated with #3588