Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide outdated comments in pull requests comparisons #4991

Closed
7 tasks
dkline opened this issue Sep 28, 2018 · 0 comments · Fixed by #5017
Closed
7 tasks

Hide outdated comments in pull requests comparisons #4991

dkline opened this issue Sep 28, 2018 · 0 comments · Fixed by #5017
Labels
Milestone

Comments

@dkline
Copy link

dkline commented Sep 28, 2018

  • Gitea version (or commit ref): 36e7cb9
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Steps to reproduce:

  • Make a PR
  • Add an inline comment to the PR
  • Update the code in the PR (update the same file and code area, throw some new lines at the top of the file as well to show the full issue.
  • Push the changes to the branch (my workflow uses rebases to squash the new commit and force push to branch)
  • View the PR in gitea
  • Note, the comment tab correctly hides the comments (they are there but collapsed and marked as outdated)
  • Looking at the files changed tab, the comments are still there, and are associated to the wrong line of code.

My suggested fix: Don't show any outdated comments on the PR diff.

Screenshots

Comment tab showing outdated comment on correct line of code:
image

File changes tab showing outdated comment on incorrect line of code (and where the correct code would be in this case):
image

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Sep 28, 2018
@jonasfranz jonasfranz added type/bug and removed type/enhancement An improvement of existing functionality labels Oct 5, 2018
@jonasfranz jonasfranz added this to the 1.6.0 milestone Oct 5, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants