PR single comments are not visible on Conversations tab

[filipnavara]

• Gitea version (or commit ref): 8db3bdc
• Git version: 2.8
• Operating system: Windows
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (https://try.gitea.io/filipnavara/test/pulls/2)
  • No
  • Not relevant
• Log gist:

Description

• Go to "Files changed" in PR
• Add comment on a line and submit with "Add single comment"
• Observe that the comment is not visible in the timeline on the Conversations page (https://try.gitea.io/filipnavara/test/pulls/2)

Adding a comment by starting a review and then submitting it with "Comment" button is visible on the Conversations page (eg. https://try.gitea.io/filipnavara/test/pulls/1).

[jonasfranz]

This is not a bug, it's expected behaviour. Please try to add "Single Comment" at GitHub. It won't show up at the timeline.

[filipnavara]

@JonasFranzDEV Definitely not true. I tried it now - filipnavara/test#1.

[jonasfranz]

@filipnavara At the time the feature got developed, this was not true. But I don't know if we want to go with GitHub's solution because it results in having no difference between Comments inside a Review (type Comment) and Code comments.

[jonasfranz]

@filipnavara Please have a look at the 4. TODO item at #3748

An option for solving this issue might be to automatically create a review if a single comment gets added. But we should discuss if we want this actually since it bloats the timeline.

[filipnavara]

It's been working like that in GitHub for at least a year and I use it all the time. Sometimes it's delayed by few seconds due to some infrastructure issues, but it always showed up. The problem is that there's no way whatsoever to tell that someone has commented on the code without actually going to the code and scrolling down.

Note that GitHub also has the notion of commenting on specific commit, which IIRC, didn't show up on the PR.

[jonasfranz]

@filipnavara E-Mail notifications will be sent. But I see your point and I propose to add this functionality to "Add single comment".

[filipnavara]

E-mail notifications are great if they are enabled, which was not the case for us. ;-)

[filipnavara]

Apparently even single comment on a specific commit in a PR still shows up on GitHub now (filipnavara/test#2), but I am fairly certain that was not always the case or that I hit some edge cases where it was not included in the conversation.

[andreymal]

I think it's an important feature. It's very easy to miss a helpful or important comment without it. The GitHub behavior does not matter here.

[lakesare]

As a side note, - right now Github does always show single comments, but it's true that it can get delayed, e.g. one of my comments got delayed 18 minutes.

[lafriks]

I agree that single comment should show just like review comment