Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Diff Stats #5532

Closed
2 of 6 tasks
Cellebyte opened this issue Dec 12, 2018 · 5 comments · Fixed by #8581
Closed
2 of 6 tasks

[PR] Diff Stats #5532

Cellebyte opened this issue Dec 12, 2018 · 5 comments · Fixed by #8581
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.10.0

Comments

@Cellebyte
Copy link

Cellebyte commented Dec 12, 2018 •
edited
Loading

Description

Click show Diff Stats in the provided pull request, scroll down and the files do not scroll down. The diffs in the background are scrolling.
...

Screenshots

screenshot from 2018-12-12 16-08-41
@Cellebyte Cellebyte changed the title [PR Feature] [PR] Diff Stats Dec 12, 2018
@lunny lunny added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Dec 12, 2018
@stale
Copy link

stale bot commented Feb 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 11, 2019
@Cellebyte
Copy link
Author

It is not stale its a bug in the frontend view.

@stale stale bot removed the issue/stale label Feb 11, 2019
@lunny lunny added type/bug issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed type/enhancement An improvement of existing functionality labels Feb 11, 2019
@joesaunderson joesaunderson mentioned this issue Jul 19, 2019
Closed
@6543
Copy link
Member

6543 commented Oct 18, 2019 •
edited
Loading

<div style="overflow-y:auto;"> ?

@6543
Copy link
Member

6543 commented Oct 18, 2019

I'll look at it

@6543 6543 mentioned this issue Oct 18, 2019
Merged
@6543
Copy link
Member

6543 commented Oct 18, 2019

ok got it :)

-> #8581

@lafriks lafriks added this to the 1.10.0 milestone Oct 18, 2019
zeripath pushed a commit that referenced this issue Oct 21, 2019
@6543 @zeripath
Ensure that diff stats can scroll independently of the diff (#8581)
b1c1e15 
This PR ensures that once opened the diff stats detail box can be scrolled independently of the diff on the compare page.

Fixes #5532 

Details:

* make diff-detail-box the main container
* move file diff at the same level as diff-stats
* make diff-view options sticy again
* make diff-stats scroll if to mouch
* rm useless css info
* less: mv diff-stats to own class
* use new css class
* cleanup less file
* diff-counter: margin-right: 15px;
* make CI work
* make numbers colorful
* add sign (-/+) to numbers
6543 added a commit to 6543-forks/gitea that referenced this issue Oct 21, 2019
@6543
Ensure that diff stats can scroll independently of the diff (go-gitea…
e8ad31d 
…#8581)

This PR ensures that once opened the diff stats detail box can be scrolled independently of the diff on the compare page.

Fixes go-gitea#5532 

Details:

* make diff-detail-box the main container
* move file diff at the same level as diff-stats
* make diff-view options sticy again
* make diff-stats scroll if to mouch
* rm useless css info
* less: mv diff-stats to own class
* use new css class
* cleanup less file
* diff-counter: margin-right: 15px;
* make CI work
* make numbers colorful
* add sign (-/+) to numbers
@6543 6543 mentioned this issue Oct 21, 2019
Merged
lunny pushed a commit that referenced this issue Oct 21, 2019
@6543 @lunny
Ensure that diff stats can scroll independently of the diff (#8581) (#…
cf35355 
…8611)

This PR ensures that once opened the diff stats detail box can be scrolled independently of the diff on the compare page.

Fixes #5532 

Details:

* make diff-detail-box the main container
* move file diff at the same level as diff-stats
* make diff-view options sticy again
* make diff-stats scroll if to mouch
* rm useless css info
* less: mv diff-stats to own class
* use new css class
* cleanup less file
* diff-counter: margin-right: 15px;
* make CI work
* make numbers colorful
* add sign (-/+) to numbers
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Fix 5532 diff stats 6543-forks/gitea
Fix 'Diff stats' scroll error
4 participants
@lunny @lafriks @Cellebyte @6543