Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Protected branches] Add commit status check #5961

Closed
pando85 opened this issue Feb 4, 2019 · 4 comments
Closed

[Protected branches] Add commit status check #5961

pando85 opened this issue Feb 4, 2019 · 4 comments
Labels
issue/duplicate The issue has already been reported.

Comments

@pando85
Copy link

pando85 commented Feb 4, 2019

I will like to propose a new feature: Block merge PR if build does not pass like in Github. This could be a protected branch option and if not commit status pass you cannot merge it.
Jenkins and Drone have implementations of commit status.
@lunny
Copy link
Member

lunny commented Feb 6, 2019

This should be duplicated issue.

@pando85
Copy link
Author

pando85 commented Feb 6, 2019

I didn't find it, sorry. If you give me ticket number I could follow it. Thanks!

@MarkusAmshove
Copy link
Contributor

#996 and #3588 are similar. Searched for ci.
I'm not sure if #996 covers approval

@lafriks
Copy link
Member

lafriks commented Feb 6, 2019

Duplicate of #3588

@lafriks lafriks marked this as a duplicate of #3588 Feb 6, 2019
@lafriks lafriks added the issue/duplicate The issue has already been reported. label Feb 6, 2019
@lafriks lafriks closed this as completed Feb 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lunny @lafriks @MarkusAmshove @pando85