Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label emojis aren't rendered in milestone view #6325

Closed
1 task done
Aragur opened this issue Mar 14, 2019 · 4 comments · Fixed by #6328
Closed
1 task done

Label emojis aren't rendered in milestone view #6325

Aragur opened this issue Mar 14, 2019 · 4 comments · Fixed by #6328
Labels

Comments

@Aragur
Copy link

Aragur commented Mar 14, 2019

Description

Emojis in labels aren't rendering when using the milestone view.

Screenshots

Milestone View
Expected behavior

@jolheiser
Copy link
Member

Looks like this page also doesn't have the same UI changes made to the issues page.
Thanks for catching this, I'll try to whip up a PR for it. 👍

@jolheiser
Copy link
Member

jolheiser commented Mar 14, 2019

Side-note, I cannot get to the posted milestone page. It seems that seeing the milestone page that lists all issues/PRs requires write access to either issues or pulls. Shouldn't it be read access to see the page?

m.Group("/milestone", func() {
m.Get("/:id", repo.MilestoneIssuesAndPulls)
}, reqRepoIssuesOrPullsWriter, context.RepoRef())

@lunny
Copy link
Member

lunny commented Mar 14, 2019

@jolheiser I think that maybe another bug but after you change that to reqRepoIssuesOrPullsReader, you also need to change the UI to disable Edit milestone and change status of issues or pulls if user haven't reqRepoIssuesOrPullsWriter.

@jolheiser
Copy link
Member

@lunny Sounds good. I'll open a new issue to address that, since I'd rather get the UI fixes in first for this issue.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants