Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add same changes from issues page to milestone->issues page #6328

Merged
merged 6 commits into from
Mar 15, 2019

Conversation

jolheiser
Copy link
Member

@jolheiser jolheiser commented Mar 14, 2019

Fixes #6325
Fixes #6331

milestone
can_close_issue

Also added some missed emoji classes to the issue list page, as well as for this milestone page.
cleanup

Cleanup some missed spots for emoji in issue page

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@lunny lunny added the type/bug label Mar 14, 2019
@codecov-io
Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #6328 into master will decrease coverage by 0.02%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6328      +/-   ##
==========================================
- Coverage   38.88%   38.85%   -0.03%     
==========================================
  Files         359      359              
  Lines       51183    51191       +8     
==========================================
- Hits        19901    19892       -9     
- Misses      28416    28432      +16     
- Partials     2866     2867       +1
Impacted Files Coverage Δ
routers/repo/milestone.go 0% <0%> (ø) ⬆️
routers/routes/routes.go 83.08% <100%> (ø) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583968f...6d72966. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2019
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Copy link
Member Author

jolheiser commented Mar 14, 2019

Added changes to fix #6331

It turned out to be a fairly small change since this PR already took care of hiding the open/close actions for non-write users.
view

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@techknowlogick techknowlogick added this to the 1.8.0 milestone Mar 14, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2019
@techknowlogick techknowlogick merged commit c55bdca into go-gitea:master Mar 15, 2019
@jolheiser jolheiser deleted the fix_milestones branch March 15, 2019 16:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Milestone returns 404 if user cannot write issue/pulls Label emojis aren't rendered in milestone view
7 participants