View Milestone returns 404 if user cannot write issue/pulls

[jolheiser]

• Gitea version (or commit ref): d7542bf
• Can you reproduce the bug at https://try.gitea.io:
  • Yes https://try.gitea.io/AragurDEV/LabelEmojiBug/milestone/400

Description

Viewing a milestone results in a 404 for all non-write users. Anyone should be able to view the milestone's issues/pulls.

I believe the issue is here:

gitea/routers/routes/routes.go

Lines 636 to 638 in 8fffb06

	m.Group("/milestone", func() {
	m.Get("/:id", repo.MilestoneIssuesAndPulls)
	}, reqRepoIssuesOrPullsWriter, context.RepoRef())

Relevant insight from @lunny:

I think that maybe another bug but after you change that to reqRepoIssuesOrPullsReader, you also need to change the UI to disable Edit milestone and change status of issues or pulls if user haven't reqRepoIssuesOrPullsWriter.