Webhook for slack sent wrong username

[stani0502]

• Gitea version (or commit ref):
• Git version: 1.8.3
• Operating system: ubuntu
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Issue on webhook for slack, when tried to modify release tag (edit or deleting), the notification always show the creator name.
For example :

1. User A creating tag v1.0.0
   Slack Notification: [RepoName] new release v1.0.0 published by User A
2. User B updating content for tag v1.0.0
   Select Notification: [RepoName] new release v1.0.0 updated by User A
3. User B delete tag v1.0.0
   Select Notification: [RepoName] new release v1.0.0 deleted by User A
   ...

Screenshots

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[sapk]

I think it come from

gitea/models/release.go

Line 467 in 85202d4

Sender: rel.Publisher.APIFormat(),

and

gitea/models/release.go

Line 412 in 85202d4

Sender: rel.Publisher.APIFormat(),

where it should be doer and not rel.Publisher

This could be tagged as a good first issue.

[lafriks]

wasn't this already fixed in 1.9.x?

[lunny]

#7774 should already fix a slack problem but not this one.