Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locked issue UI broken #7304

Closed
lunny opened this issue Jun 26, 2019 · 8 comments · Fixed by #7355
Closed

Locked issue UI broken #7304

lunny opened this issue Jun 26, 2019 · 8 comments · Fixed by #7355
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.9.0

Comments

@lunny
Copy link
Member

lunny commented Jun 26, 2019

image
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 26, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 26, 2019
@Cherrg
Copy link
Contributor

Cherrg commented Jun 28, 2019

May I ask whats broken there?
As I never used this feature before, I don't know what it should look like.
(Should the symbol be placed more to the left?)

This is how it looks on my side:
grafik

(The thing I found was a spelling bug in german translation on the lock message :) )

@lunny
Copy link
Member Author

lunny commented Jun 29, 2019

Maybe on an archived repository I think.

@lunny
Copy link
Member Author

lunny commented Jul 2, 2019

see https://gitea.com/gitea/git/issues/72

@Cherrg
Copy link
Contributor

Cherrg commented Jul 2, 2019

-> may "locked repo" message is missing, i will check later today

Cherrg added a commit to Cherrg/gitea that referenced this issue Jul 3, 2019
@Cherrg
add 'repo archived - comment/pull not possible' message
01fe0de 
affects go-gitea#7304

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@Cherrg Cherrg mentioned this issue Jul 3, 2019
Merged
@Cherrg
Copy link
Contributor

Cherrg commented Jul 3, 2019

does #7345 addresses or fix this issue?

@Cherrg
Copy link
Contributor

Cherrg commented Jul 3, 2019

is this line the problem?
grafik

@lunny
Copy link
Member Author

lunny commented Jul 4, 2019

@Cherrg right.

Cherrg added a commit to Cherrg/gitea that referenced this issue Jul 4, 2019
@Cherrg
cut timeline length with last element on issue view
a39fe62 
fix go-gitea#7304

- lightly enlight dark theme issue timeline color

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@Cherrg Cherrg mentioned this issue Jul 4, 2019
Merged
@Cherrg
Copy link
Contributor

Cherrg commented Jul 4, 2019

#7355 should fix this

zeripath pushed a commit that referenced this issue Jul 6, 2019
@Cherrg @zeripath
ui - cut timeline length with last element on issue view (#7355)
5b92bc1 
* cut timeline length with last element on issue view

fix #7304

- lightly enlight dark theme issue timeline color

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* remove new container

Signed-off-by: Michael Gnehr <michael@gnehr.de>
zeripath pushed a commit that referenced this issue Jul 8, 2019
@Cherrg @zeripath
ui fixes - compare view and archieved repo issues (#7345)
3c3f749 
* add 'repo archived - comment/pull not possible' message

affects #7304

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* add navbar to compare view

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* remove wrong if else

Signed-off-by: Michael Gnehr <michael@gnehr.de>
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this issue Jul 18, 2019
@Cherrg @jeffliu27
ui - cut timeline length with last element on issue view (go-gitea#7355)
df7718b 
* cut timeline length with last element on issue view

fix go-gitea#7304

- lightly enlight dark theme issue timeline color

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* remove new container

Signed-off-by: Michael Gnehr <michael@gnehr.de>
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this issue Jul 18, 2019
@Cherrg @jeffliu27
ui fixes - compare view and archieved repo issues (go-gitea#7345)
27c68dc 
* add 'repo archived - comment/pull not possible' message

affects go-gitea#7304

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* add navbar to compare view

Signed-off-by: Michael Gnehr <michael@gnehr.de>

* remove wrong if else

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

ui - cut timeline length with last element on issue view Cherrg/gitea
2 participants
@lunny @Cherrg