Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding a default set of githooks and webhooks #770

Closed
alvaroaleman opened this issue Jan 26, 2017 · 4 comments
Closed

Allow adding a default set of githooks and webhooks #770

alvaroaleman opened this issue Jan 26, 2017 · 4 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.9.0

Comments

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Jan 26, 2017 •
edited by lunny
Loading

It would be nice if it was possible to configure a default set of githooks and webhooks in the admin interface and/or at organization level.

That default set should then be applied to all newly created repositories. It should also be possible to use the repository name as variable.
@alvaroaleman alvaroaleman changed the title Allow adding a default set of git and webhooks Allow adding a default set of githooks and webhooks Jan 26, 2017
@lunny lunny added this to the 1.x.x milestone Jan 26, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 26, 2017
@lunny lunny mentioned this issue Sep 1, 2017
Closed
6 tasks
@charlesreid1
Copy link
Contributor

Agreed! This would also make it much simpler to set up a static page hosting service, Github Pages style. You can create a webhook that triggers a site builder on commit to a particular branch, and have it installed on all pages by default.

@lunny lunny mentioned this issue May 21, 2018
Open
7 tasks
@aunger
Copy link
Contributor

aunger commented Jun 19, 2018 •
edited
Loading

I'm going to take a crack at this, but I'd like some design feedback on the question of default vs all.

For my purposes, adding an admin set of web hooks for all repos would be sufficient. These would be invisible to the individual org and repo settings pages, and could only be altered by admin. As the administrator of the system, I want my own set of hooks to fire upon pushes, for example.

As I understand #770, it requests default webhooks instead, which are copied into new orgs and new repos, and may then be altered or deleted by the org/repo owner. This could work for my needs, too.

I can implement whichever is more likely to be merged. Thanks! Thoughts?

aunger added a commit to aunger/gitea that referenced this issue Jun 22, 2018
@aunger
Implement Default Webhooks
30ba097 
Partially implement go-gitea#770.
Add "Default Webhooks" page in site admin UI.
Persist to the existing webhooks table, but store with RepoID=0 and OrgID=0.
Upon repo creation, copy the set of default webhooks into the new repo.

Signed-off-by: Russell Aunger <rba@live.com>
@aunger aunger mentioned this issue Jun 22, 2018
Merged
aunger added a commit to aunger/gitea that referenced this issue Jun 26, 2018
@aunger
Implement Default Webhooks
6ce6c83 
Back-port to v1.4 for Wycliffe use.

Partially implement go-gitea#770.
Add "Default Webhooks" page in site admin UI.
Persist to the existing webhooks table, but store with RepoID=0 and OrgID=0.
Upon repo creation, copy the set of default webhooks into the new repo.

Signed-off-by: Russell Aunger <rba@live.com>
@techknowlogick techknowlogick mentioned this issue Jul 17, 2018
Closed
7 tasks
aunger added a commit to aunger/gitea that referenced this issue Aug 8, 2018
@aunger
Implement Default Webhooks
53ace19 
Back-port to v1.4 for Wycliffe use.

Partially implement go-gitea#770.
Add "Default Webhooks" page in site admin UI.
Persist to the existing webhooks table, but store with RepoID=0 and OrgID=0.
Upon repo creation, copy the set of default webhooks into the new repo.

Signed-off-by: Russell Aunger <rba@live.com>
@stale
Copy link

stale bot commented Jan 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 23, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 7, 2019
techknowlogick pushed a commit that referenced this issue Mar 19, 2019
@aunger @techknowlogick
Implement Default Webhooks (#4299)
b34996a 
Partially implement #770.
Add "Default Webhooks" page in site admin UI.
Persist to the existing webhooks table, but store with RepoID=0 and OrgID=0.
Upon repo creation, copy the set of default webhooks into the new repo.
@techknowlogick
Copy link
Member

Closed per merged PR

@techknowlogick techknowlogick modified the milestones: 1.x.x, 1.9.0 Mar 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
5 participants
@lunny @techknowlogick @charlesreid1 @aunger @alvaroaleman