No branches of fork visible on new Pull Request

[mxmehl]

• Gitea version (or commit ref): g52feff5a5
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

Since upgrading to 1.9.0, one cannot see branches of their fork any more when creating a new pull request upstream.

Example: In my fork of go-gitea/chardet on try.gitea.io, I have created the branch test-pr. When clicking on New Pull Request in the upstream repo, I cannot find my own branch there, only branches from the repo itself.

This is unusual behaviour and makes it hard for people to create a pull request. Not sure if it's a regression or an intended change though.

[lunny]

When you click the New Pull Request from your fork repo, that it is.

[mxmehl]

Isn't that a bit counter-intuitive? I want to create a pull request at upstream, not my fork.

This way, it's also harder to document for git beginners because the URL for creating pull requests is individual per user.

[lafriks]

This could definitely be improved, there should be issue about this imho already

[lunny]

We need a PR to do that.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.

[jancborchardt]

Just ran into this as well. I’m a regular Github user where this just works, and this was a huge blocker where I thought I was doing something wrong.

So I’d say definitely not stale, and if you point out where in the code work on this would need to be started, it could be a good first issue? :)

[guillep2k]

@jancborchardt This has been fixed in 1.10 I believe. Probably backported to 1.9.6 as well. What's your version?

[mxmehl]

On 1.9.6 and when creating a pull request using the upstream's "Pull Request" button (e.g. https://git.fsfe.org/org/repo/compare/master...master) does not show the fork's branches, so it does not seem to be backported.

I haven't tested 1.10 yet as I would like to wait for 1.10.1 to be released. But from the changelog I cannot see an enhancement or fix that might match the issue described here, but I might be wrong

[guillep2k]

@mxmehl It was in the current 1.11.0, although the title is not very descriptive: #8670

[mxmehl]

Ah yes, that looks like it. Thanks a lot, looking forward to upgrading soon :)

[davidsvantesson]

That PR didn't really change what the poster requested. The poster wanted to see all fork branches when making new pull request in the upstream repo.
I am not sure if that makes sense as there can be a lot of forks.

[mxmehl]

Right, it's still not working as before.

I do not want to see all forks but only my own one + the upstream's. In 95% of the cases, the are the two sources from which a user will create pull requests.